You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/22 08:32:55 UTC
[GitHub] [dolphinscheduler-website] QuakeWang opened a new pull request #748: [New UI] Update the new UI of dev document
QuakeWang opened a new pull request #748:
URL: https://github.com/apache/dolphinscheduler-website/pull/748
Updated website with new UI screenshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] QuakeWang commented on pull request #748: [New UI] Update the new UI of dev document
Posted by GitBox <gi...@apache.org>.
QuakeWang commented on pull request #748:
URL: https://github.com/apache/dolphinscheduler-website/pull/748#issuecomment-1074878354
@zhongjiajie PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #748: [New UI] Update the new UI of dev document
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #748:
URL: https://github.com/apache/dolphinscheduler-website/pull/748#discussion_r832778497
##########
File path: docs/en-us/dev/user_doc/guide/datasource/hive.md
##########
@@ -2,9 +2,7 @@
## Use HiveServer2
- <p align="center">
- <img src="/img/hive-en.png" width="80%" />
- </p>
+
Review comment:
Good point to add new directory to keep new ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #748: [New UI] Update the new UI of dev document
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #748:
URL: https://github.com/apache/dolphinscheduler-website/pull/748#discussion_r832785582
##########
File path: docs/en-us/dev/user_doc/guide/datasource/hive.md
##########
@@ -2,9 +2,7 @@
## Use HiveServer2
- <p align="center">
- <img src="/img/hive-en.png" width="80%" />
- </p>
+
Review comment:
also good to use markdown syntax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie merged pull request #748: [New UI] Update the new UI of dev document
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #748:
URL: https://github.com/apache/dolphinscheduler-website/pull/748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #748: [New UI] Update the new UI of dev document
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #748:
URL: https://github.com/apache/dolphinscheduler-website/pull/748#issuecomment-1075206059
Thanks for your contribution, I will take a look tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] QuakeWang commented on a change in pull request #748: [New UI] Update the new UI of dev document
Posted by GitBox <gi...@apache.org>.
QuakeWang commented on a change in pull request #748:
URL: https://github.com/apache/dolphinscheduler-website/pull/748#discussion_r832789687
##########
File path: docs/en-us/dev/user_doc/guide/datasource/hive.md
##########
@@ -2,9 +2,7 @@
## Use HiveServer2
- <p align="center">
- <img src="/img/hive-en.png" width="80%" />
- </p>
+
Review comment:
> Good point to add new directory to keep new ui
It's good for the organization and standardization of the images later on, so I chose to create a new catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org