You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/08 07:43:04 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #10130: Reduce redundant logs on Producer/Consumer create/close operations

eolivelli commented on a change in pull request #10130:
URL: https://github.com/apache/pulsar/pull/10130#discussion_r609408102



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1193,7 +1193,7 @@ protected void handleProducer(final CommandProducer cmdProducer) {
                                 topic.addProducer(producer, producerQueuedFuture).thenAccept(newTopicEpoch -> {
                                     if (isActive()) {
                                         if (producerFuture.complete(producer)) {
-                                            log.info("[{}] Created new producer: {}", remoteAddress, producer);
+                                            log.debug("[{}] Created new producer: {}", remoteAddress, producer);

Review comment:
       @merlimat I see your point, here we are sure that the producer is actually "active".
   What about reducing log level of "Creating producer. " instead of this line ?
   
   the problem is the amount of logs we see when the system is working properly, we have 2 or 3 lines per producer, and this is a certain waste of log resources. 
   the problem is more evident in case of short lived producers (like health checks)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org