[jira] [Commented] (FLINK-7393) Move unit tests of KinesisConfigUtil from FlinkKinesisConsumerTest to KinesisConfigUtilTest

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177311#comment-16177311 ] 

ASF GitHub Bot commented on FLINK-7393:
---------------------------------------

GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/4708

    [FLINK-7393][kinesis connector] Move unit tests that should belong to KinesisConfigUtil from FlinkKinesisConsumerTest to KinesisConfigUtilTest

    ## What is the purpose of the change
    
    Right now, `FlinkKinesisConsumerTest` has lots of unit tests that actually should belong to `KinesisConfigUtil`, e.g. all the `validateXxxConfiguration()`
    
    We need to move those tests out to a new file `KinesisConfigUtilTest`
    
    ## Brief change log
    
    - Move unit tests that should belong to KinesisConfigUtil from FlinkKinesisConsumerTest to KinesisConfigUtilTest
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    This change is already covered by existing tests, such as *(please describe tests)*.
    
    ## Does this pull request potentially affect one of the following parts:
    
    none
    
    ## Documentation
    
    none


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-7223

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4708
    
----
commit 8ba44053ea96220fd74a357ff612bebf65553cb7
Author: Bowen Li <bo...@gmail.com>
Date:   2017-09-22T23:10:56Z

    FLINK-7393 Move unit tests of KinesisConfigUtil from FlinkKinesisConsumerTest to KinesisConfigUtilTest

----


> Move unit tests of KinesisConfigUtil from FlinkKinesisConsumerTest to KinesisConfigUtilTest
> -------------------------------------------------------------------------------------------
>
>                 Key: FLINK-7393
>                 URL: https://issues.apache.org/jira/browse/FLINK-7393
>             Project: Flink
>          Issue Type: Test
>          Components: Kinesis Connector
>    Affects Versions: 1.3.2
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> Right now, [{{FlinkKinesisConsumerTest}}|https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java] has lots of tests that actually should belong to {{KinesisConfigUtil}}, e.g. all the {{validateXxxConfiguration()}}
> We need to move those tests out to a new file {{KinesisConfigUtilTest}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)