You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2021/04/27 08:03:40 UTC
[GitHub] [unomi] giladw opened a new pull request #302: use name for path to location if exists, like in GeoLocationByPointSe…
giladw opened a new pull request #302:
URL: https://github.com/apache/unomi/pull/302
…ssionConditionESQueryBuilder
PR Title format:
[UNOMI-XXX] Pull request title with JIRA reference
**Please** add a meaningful description for your change here
----
**Please** following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/UNOMI) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Format the pull request title like `[UNOMI-XXX] - Title of the pull request`
- [ ] Provide integration tests for your changes, especially if you are changing the behavior of existing code or adding
significant new parts of code.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Copy the description to the related JIRA issue
- [ ] Run `mvn clean install -P integration-tests` to make sure basic checks pass. A more thorough check will be
performed on your pull request automatically.
Trivial changes like typos do not require a JIRA issue (javadoc, project build changes, small doc changes, comments...).
If this is your first contribution, you have to read the [Contribution Guidelines](https://unomi.apache.org/contribute.html)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] dgriffon commented on pull request #302: UNOMI-473-use name for path to location if exists, like in GeoLocationByPointSe…
Posted by GitBox <gi...@apache.org>.
dgriffon commented on pull request #302:
URL: https://github.com/apache/unomi/pull/302#issuecomment-846872935
Can you please provide a scenario, or more detail on how to use that parameter in the JIRA ticket? Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber commented on pull request #302: use name for path to location if exists, like in GeoLocationByPointSe…
Posted by GitBox <gi...@apache.org>.
sergehuber commented on pull request #302:
URL: https://github.com/apache/unomi/pull/302#issuecomment-829347963
Hi @giladw could you add the JIRA ticket to the PR title to make it easier to cross reference ? Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] jkevan merged pull request #302: UNOMI-473-use name for path to location if exists, like in GeoLocationByPointSe…
Posted by GitBox <gi...@apache.org>.
jkevan merged pull request #302:
URL: https://github.com/apache/unomi/pull/302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] giladw commented on pull request #302: UNOMI-473-use name for path to location if exists, like in GeoLocationByPointSe…
Posted by GitBox <gi...@apache.org>.
giladw commented on pull request #302:
URL: https://github.com/apache/unomi/pull/302#issuecomment-829891092
@sergehuber edited the title of the pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org