You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/01 11:51:07 UTC
[GitHub] [iotdb] xinzhongtianxia commented on a change in pull request #5147: [IOTDB-2638][Metric] add features into metric module.
xinzhongtianxia commented on a change in pull request #5147:
URL: https://github.com/apache/iotdb/pull/5147#discussion_r816700484
##########
File path: metrics/interface/src/main/assembly/resources/conf/iotdb-metric.yml
##########
@@ -40,8 +43,6 @@ pushPeriodInSecond: 5
# #
# if the reporter is prometheus, #
# then the following must be set. #
-# if you use dropwizard, all below #
-# should be the config of pushgateway #
# #
########################################################
prometheusReporterConfig:
Review comment:
Since we removed the push_gateway, the prometheusExporterUrl becomes useless.
Then all the three lines could be replaced by a simple config: `prometheusExporterPort: 9091`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org