You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martijn Dashorst <ma...@gmail.com> on 2012/07/19 15:24:56 UTC

BookmarkablePageLink and generics

Is there, apart from the hierarchy, a reason why BookmarkablePageLink
is generified? It seems utterly useless in my opinion, but I might
miss some use case.

If it is actually not necessary to generify BPL, can we somehow fix
that, preferrably before 6.0 final?

Martijn

-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com

Re: BookmarkablePageLink and generics

Posted by Martijn Dashorst <ma...@gmail.com>.
On Thu, Jul 19, 2012 at 3:28 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> you can declare it as extends Link<Void> or extends Link<Object>
>
> if we want to be potentially non-backwards-compat we can declare it as
> Link<PageParameters> and save some memory by storing the params in the
> model's slot instead of its own

Sounds like you're on to something. I like the idea that a BPL is a
Link<PageParameters>.

Unfortunately, BPL does not have a working onClick, so somehow the
typing/naming seems off.

I guess that in the past we actually should've named Link ActionLink,
and let BPL extend AbstractLink.

Martijn

Re: BookmarkablePageLink and generics

Posted by Bertrand Guay-Paquet <be...@step.polymtl.ca>.
Hi,

You guys are so 2011! I actually opened an issue regarding this about a 
year ago :) WICKET-3521

Regards,
Bertrand

On 19/07/2012 9:34 AM, Sebastien wrote:
> Hi Marttijn, Hi Igor,
>
> If you plan to fix it, would it also be relevant to change StatelessLink<T>
> ? The generic on StatelessLink appears on 1.5 but I do not really see why...
>
> Thanks&  best regards,
> Sebastien.
>
> On Thu, Jul 19, 2012 at 3:28 PM, Igor Vaynberg<ig...@gmail.com>wrote:
>
>> you can declare it as extends Link<Void>  or extends Link<Object>
>>
>> if we want to be potentially non-backwards-compat we can declare it as
>> Link<PageParameters>  and save some memory by storing the params in the
>> model's slot instead of its own
>>
>> -igor
>>
>> On Thu, Jul 19, 2012 at 4:24 PM, Martijn Dashorst
>> <ma...@gmail.com>  wrote:
>>> Is there, apart from the hierarchy, a reason why BookmarkablePageLink
>>> is generified? It seems utterly useless in my opinion, but I might
>>> miss some use case.
>>>
>>> If it is actually not necessary to generify BPL, can we somehow fix
>>> that, preferrably before 6.0 final?
>>>
>>> Martijn
>>>
>>> --
>>> Become a Wicket expert, learn from the best: http://wicketinaction.com

Re: BookmarkablePageLink and generics

Posted by Sebastien <se...@gmail.com>.
Hi Marttijn, Hi Igor,

If you plan to fix it, would it also be relevant to change StatelessLink<T>
? The generic on StatelessLink appears on 1.5 but I do not really see why...

Thanks & best regards,
Sebastien.

On Thu, Jul 19, 2012 at 3:28 PM, Igor Vaynberg <ig...@gmail.com>wrote:

> you can declare it as extends Link<Void> or extends Link<Object>
>
> if we want to be potentially non-backwards-compat we can declare it as
> Link<PageParameters> and save some memory by storing the params in the
> model's slot instead of its own
>
> -igor
>
> On Thu, Jul 19, 2012 at 4:24 PM, Martijn Dashorst
> <ma...@gmail.com> wrote:
> > Is there, apart from the hierarchy, a reason why BookmarkablePageLink
> > is generified? It seems utterly useless in my opinion, but I might
> > miss some use case.
> >
> > If it is actually not necessary to generify BPL, can we somehow fix
> > that, preferrably before 6.0 final?
> >
> > Martijn
> >
> > --
> > Become a Wicket expert, learn from the best: http://wicketinaction.com
>

Re: BookmarkablePageLink and generics

Posted by Igor Vaynberg <ig...@gmail.com>.
you can declare it as extends Link<Void> or extends Link<Object>

if we want to be potentially non-backwards-compat we can declare it as
Link<PageParameters> and save some memory by storing the params in the
model's slot instead of its own

-igor

On Thu, Jul 19, 2012 at 4:24 PM, Martijn Dashorst
<ma...@gmail.com> wrote:
> Is there, apart from the hierarchy, a reason why BookmarkablePageLink
> is generified? It seems utterly useless in my opinion, but I might
> miss some use case.
>
> If it is actually not necessary to generify BPL, can we somehow fix
> that, preferrably before 6.0 final?
>
> Martijn
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com