You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/02 15:15:10 UTC
[GitHub] [dubbo-go] gaoxinge opened a new pull request #1361: support multi pb
gaoxinge opened a new pull request #1361:
URL: https://github.com/apache/dubbo-go/pull/1361
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
- support multi pb
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes https://github.com/apache/dubbo-go/pull/1261#issuecomment-889575887
**Special notes for your reviewer**:
NONE
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on pull request #1361: support multi pb
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on pull request #1361:
URL: https://github.com/apache/dubbo-go/pull/1361#issuecomment-894408817
Proto files is used to test that there is no confliction when generating multi pb.go in one package, not for grpc test.
Refer to https://github.com/apache/dubbo-go/pull/1261#issuecomment-889575887 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1361: support multi pb
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1361:
URL: https://github.com/apache/dubbo-go/pull/1361#issuecomment-895734543
Did you test locally using stub generated by new protoc-gen-dubbo tools? @gaoxinge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1361: support multi pb
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1361:
URL: https://github.com/apache/dubbo-go/pull/1361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1361: support multi pb
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1361:
URL: https://github.com/apache/dubbo-go/pull/1361#discussion_r684145317
##########
File path: protocol/grpc/protoc-gen-dubbo/plugin/dubbo/dubbo.go
##########
@@ -311,6 +304,15 @@ func (g *dubboGrpc) generateServerMethod(servName, fullServName string, method *
}
streamType := unexport(servName) + methName + "Server"
g.P("func ", hname, "(srv interface{}, stream ", grpcPkg, ".ServerStream) error {")
Review comment:
这里看着像插到函数里了，这里编译后不会报错么？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on pull request #1361: support multi pb
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on pull request #1361:
URL: https://github.com/apache/dubbo-go/pull/1361#issuecomment-897416043
@LaurenceLiZhixin Yes, I have test this locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1361: support multi pb
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1361:
URL: https://github.com/apache/dubbo-go/pull/1361#issuecomment-891559480
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1361?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1361](https://codecov.io/gh/apache/dubbo-go/pull/1361?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dd20999) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/f76b01c6f439be07441cb55fafed78c94217902b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f76b01c) will **decrease** coverage by `1.28%`.
> The diff coverage is `n/a`.
> :exclamation: Current head dd20999 differs from pull request most recent head cea0b8e. Consider uploading reports for the commit cea0b8e to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1361 +/- ##
==========================================
- Coverage 56.13% 54.84% -1.29%
==========================================
Files 279 272 -7
Lines 15355 14736 -619
==========================================
- Hits 8619 8082 -537
+ Misses 5810 5781 -29
+ Partials 926 873 -53
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (-43.23%)` | :arrow_down: |
| [remoting/zookeeper/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2ZhY2FkZS5nbw==) | `0.00% <0.00%> (-40.00%)` | :arrow_down: |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `66.66% <0.00%> (-6.25%)` | :arrow_down: |
| [metadata/report/zookeeper/report.go](https://codecov.io/gh/apache/dubbo-go/pull/1361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L3pvb2tlZXBlci9yZXBvcnQuZ28=) | | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | | |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | | |
| [config\_center/zookeeper/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvZmFjdG9yeS5nbw==) | | |
| [config\_center/zookeeper/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/1361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvaW1wbC5nbw==) | | |
| [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | | |
| [registry/zookeeper/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1361/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | | |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/1361/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1361?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1361?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f76b01c...cea0b8e](https://codecov.io/gh/apache/dubbo-go/pull/1361?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1361: support multi pb
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1361:
URL: https://github.com/apache/dubbo-go/pull/1361#issuecomment-894181496
Thanks for your improvment!
Why you add proto files to grpc/internal? I can't find usage for them.
And pls add an example to samples if needed. @gaoxinge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge edited a comment on pull request #1361: support multi pb
Posted by GitBox <gi...@apache.org>.
gaoxinge edited a comment on pull request #1361:
URL: https://github.com/apache/dubbo-go/pull/1361#issuecomment-894408817
@LaurenceLiZhixin Proto files is used to test that there is no confliction when generating multi pb.go in one package, not for grpc test.
Refer to https://github.com/apache/dubbo-go/pull/1261#issuecomment-889575887 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org