You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/27 06:50:30 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #5380: vmware: check checksum while copying systemvm ISO
shwstppr opened a new pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380
### Description
For VMware, systemvm.iso is copied from MS to secondary store. Current server checks if the desired file is present on the secondary store or not. If it is not present ISO is copied.
This change adds a check for checksum for source and destination ISO which would allow copying new ISO if there is a mismatch.
Useful in case when file is corrupted in secondary store or new systemvm.iso is generated for dev environment.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-908892682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5380: vmware: check checksum while copying systemvm ISO
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-906968704
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum while copying systemvm ISO
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-906968883
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-908903607
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-910568128
<b>Trillian Build Failed (tid-1912)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-908892760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-908922858
@blueorangutan test centos7 vmware-65u2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#discussion_r700754874
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,24 @@ public VmwareManagerImpl() {
_storageMgr = new VmwareStorageManagerImpl(this);
}
+ private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+ if (!destIso.exists()) {
+ return true;
+ }
+ boolean copyNeeded = false;
+ try {
+ String srcIsoMd5 = DigestUtils.md5Hex(new FileInputStream(srcIso));
Review comment:
_srcIso_ can be null if it doesn't exists, please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-910311843
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-909687269
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-910429432
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum while copying systemvm ISO
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-906998178
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-909687269
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-910713065
<b>Trillian test result (tid-1876)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 77148 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5380-t1876-vmware-65u2.zip
Smoke tests completed. 88 look OK, 3 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_deploy_vm_start_failure | `Error` | 95.05 | test_deploy_vm.py
test_deploy_vm_volume_creation_failure | `Error` | 89.90 | test_deploy_vm.py
test_vm_ha | `Error` | 94.21 | test_vm_ha.py
test_vm_sync | `Error` | 200.34 | test_vm_sync.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#discussion_r697809964
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,18 @@ public VmwareManagerImpl() {
_storageMgr = new VmwareStorageManagerImpl(this);
}
+ private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+ boolean copyNeeded = !destIso.exists();
+ if (!copyNeeded) {
Review comment:
```suggestion
if (!destIso.exists()) {
return true;
}
```
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,18 @@ public VmwareManagerImpl() {
_storageMgr = new VmwareStorageManagerImpl(this);
}
+ private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+ boolean copyNeeded = !destIso.exists();
+ if (!copyNeeded) {
+ try {
+ copyNeeded = !StringUtils.equals(DigestUtils.md5Hex(new FileInputStream(srcIso)), DigestUtils.md5Hex(new FileInputStream(destIso)));
Review comment:
Maybe also add a log line in case copyNeeded == true?
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,18 @@ public VmwareManagerImpl() {
_storageMgr = new VmwareStorageManagerImpl(this);
}
+ private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+ boolean copyNeeded = !destIso.exists();
+ if (!copyNeeded) {
+ try {
+ copyNeeded = !StringUtils.equals(DigestUtils.md5Hex(new FileInputStream(srcIso)), DigestUtils.md5Hex(new FileInputStream(destIso)));
Review comment:
```suggestion
String srcIsoMd5 = DigestUtils.md5Hex(new FileInputStream(srcIso));
String destIsoMd5 = DigestUtils.md5Hex(new FileInputStream(destIso));
copyNeeded = !StringUtils.equals(srcIsoMd5, destIsoMd5);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-909687131
@blueorangutan test centos7 vmware-65u2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#discussion_r700766551
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,24 @@ public VmwareManagerImpl() {
_storageMgr = new VmwareStorageManagerImpl(this);
}
+ private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+ if (!destIso.exists()) {
+ return true;
+ }
+ boolean copyNeeded = false;
+ try {
+ String srcIsoMd5 = DigestUtils.md5Hex(new FileInputStream(srcIso));
Review comment:
```
private File getSystemVMPatchIsoFile() {
// locate systemvm.iso
URL url = this.getClass().getClassLoader().getResource("vms/systemvm.iso");
File isoFile = null;
if (url != null) {
isoFile = new File(url.getPath());
}
if (isoFile == null || !isoFile.exists()) {
isoFile = new File("/usr/share/cloudstack-common/vms/systemvm.iso");
}
assert (isoFile != null);
if (!isoFile.exists()) {
s_logger.error("Unable to locate systemvm.iso in your setup at " + isoFile.toString());
}
return isoFile;
}
```
Method(existed before this PR) used for getting `srcIso` covers that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-911197870
Lgtm failure not related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-909687131
@blueorangutan test centos7 vmware-65u2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#discussion_r699004797
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,18 @@ public VmwareManagerImpl() {
_storageMgr = new VmwareStorageManagerImpl(this);
}
+ private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+ boolean copyNeeded = !destIso.exists();
+ if (!copyNeeded) {
+ try {
+ copyNeeded = !StringUtils.equals(DigestUtils.md5Hex(new FileInputStream(srcIso)), DigestUtils.md5Hex(new FileInputStream(destIso)));
Review comment:
Added
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,18 @@ public VmwareManagerImpl() {
_storageMgr = new VmwareStorageManagerImpl(this);
}
+ private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+ boolean copyNeeded = !destIso.exists();
+ if (!copyNeeded) {
+ try {
+ copyNeeded = !StringUtils.equals(DigestUtils.md5Hex(new FileInputStream(srcIso)), DigestUtils.md5Hex(new FileInputStream(destIso)));
Review comment:
Done
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,18 @@ public VmwareManagerImpl() {
_storageMgr = new VmwareStorageManagerImpl(this);
}
+ private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+ boolean copyNeeded = !destIso.exists();
+ if (!copyNeeded) {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-908892682
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-910429028
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-908892760
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#discussion_r699004797
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,18 @@ public VmwareManagerImpl() {
_storageMgr = new VmwareStorageManagerImpl(this);
}
+ private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+ boolean copyNeeded = !destIso.exists();
+ if (!copyNeeded) {
+ try {
+ copyNeeded = !StringUtils.equals(DigestUtils.md5Hex(new FileInputStream(srcIso)), DigestUtils.md5Hex(new FileInputStream(destIso)));
Review comment:
Added
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,18 @@ public VmwareManagerImpl() {
_storageMgr = new VmwareStorageManagerImpl(this);
}
+ private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+ boolean copyNeeded = !destIso.exists();
+ if (!copyNeeded) {
+ try {
+ copyNeeded = !StringUtils.equals(DigestUtils.md5Hex(new FileInputStream(srcIso)), DigestUtils.md5Hex(new FileInputStream(destIso)));
Review comment:
Done
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,18 @@ public VmwareManagerImpl() {
_storageMgr = new VmwareStorageManagerImpl(this);
}
+ private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+ boolean copyNeeded = !destIso.exists();
+ if (!copyNeeded) {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-910311258
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#issuecomment-908923113
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org