You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by DaanHoogland <gi...@git.apache.org> on 2015/11/05 10:53:31 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-9037 patterns can be more elab...

GitHub user DaanHoogland opened a pull request:

    https://github.com/apache/cloudstack/pull/1035

    CLOUDSTACK-9037 patterns can be more elaborate then prefixes.

    little fix to make sure for instance "eth" is not regarded as interface when it is part of "methamfetamine"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9037

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1035.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1035
    
----
commit 57ea4506e1f84174a8fb53e70d4901f2a4bb7c24
Author: Daan Hoogland <da...@onecht.net>
Date:   2015-11-05T09:49:17Z

    CLOUDSTACK-9037 patterns can be more elaborate then prefixes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9037 patterns can be more elab...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1035


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9037 patterns can be more elab...

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1035#issuecomment-159179464
  
    [1035.network.results.txt](https://github.com/apache/cloudstack/files/42442/1035.network.results.txt)
    [1035.vpc.results.txt](https://github.com/apache/cloudstack/files/42443/1035.vpc.results.txt)
    
    @remibergsma @karuturi simple fix, can you merge?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9037 patterns can be more elab...

Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:

    https://github.com/apache/cloudstack/pull/1035#issuecomment-154019836
  
    tested. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9037 patterns can be more elab...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/1035#issuecomment-158875017
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---