[GitHub] [airflow] ashb commented on a change in pull request #5339: [AIRFLOW-3160] (Unrevert) Load latest_dagruns asynchronously

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5339: [AIRFLOW-3160] (Unrevert) Load latest_dagruns asynchronously
URL: https://github.com/apache/airflow/pull/5339#discussion_r289060178
 
 

 ##########
 File path: airflow/www/templates/airflow/dags.html
 ##########
 @@ -103,13 +103,11 @@ <h2>DAGs</h2>
 
                 <!-- Column 7: Last Run -->
                 <td class="text-nowrap latest_dag_run {{ dag.dag_id }}">
-                  {% set last_run = dag.get_last_dagrun(include_externally_triggered=True) %}
-                  {% if last_run and last_run.execution_date %}
-                    <a href="{{ url_for('Airflow.graph', dag_id=dag.dag_id, execution_date=last_run.execution_date) }}">
-                      {{ last_run.execution_date.strftime("%Y-%m-%d %H:%M") }}
-                    </a>
-                    <span aria-hidden="true" id="statuses_info" title="Start Date: {{ last_run.start_date.strftime("%Y-%m-%d %H:%M") }}" class="glyphicon glyphicon-info-sign"></span>
-                  {% endif %}
+                  <div height="10" width="10" id='last-run-{{ dag.safe_dag_id }}' style="display: block;">
+                    <a></a>
+                    <img class="loading-last-run" width="15" src="{{ url_for("static", filename="loading.gif") }}">
 
 Review comment:
   This image is wider than the div it's in - does it look okay?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services