You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/05 15:23:19 UTC

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #2814: graphics: Author: Gregory Nutt: update licenses to Apache

jerpelea opened a new pull request #2814:
URL: https://github.com/apache/incubator-nuttx/pull/2814


   ## Summary
   License change to Apache 2.0
   
   ## Impact
   None 
   
   ## Testing
   local nxstyle run
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #2814: graphics: Author: Gregory Nutt: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2814:
URL: https://github.com/apache/incubator-nuttx/pull/2814


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #2814: graphics: Author: Gregory Nutt: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2814:
URL: https://github.com/apache/incubator-nuttx/pull/2814#issuecomment-774487299


   > @jerpelea , need to clear some small nxstyle warning:
   > https://github.com/apache/incubator-nuttx/pull/2814/checks?check_run_id=1839787184
   
   Hi @xiaoxiang781216 I think he cannot do it, see: ASCII_a and ASCII_A
   
   This file is an exception that confirm the rule ;-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2814: graphics: Author: Gregory Nutt: update licenses to Apache

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2814:
URL: https://github.com/apache/incubator-nuttx/pull/2814#issuecomment-774489438


   But there are other nxstyle warnings we can fix:
   ```
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/graphics/nxterm/nxterm.h:1:77: error: Block comments have different lengths
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/graphics/nxterm/nxterm.h:43:74: error: Block comments have different lengths
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/graphics/nxterm/nxterm.h:106:48: error: Missing space before closing C comment
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/graphics/nxterm/nxterm.h:189:80: error: Long line found
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/graphics/nxterm/nxterm.h:213:80: error: Long line found
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/graphics/nxterm/nxterm.h:220:81: error: Long line found
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/graphics/vnc/server/vnc_keymap.c:125:1: error: Blank line precedes right brace at line
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/graphics/vnc/server/vnc_keymap.c:129:1: error: Blank line follows left brace
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/graphics/vnc/server/vnc_keymap.c:132:1: error: Blank line precedes right brace at line
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/graphics/vnc/server/vnc_receiver.c:280:86: error: Long line found
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org