You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/10 09:05:38 UTC

[GitHub] [iceberg] pvary commented on pull request #2210: Adds AddFiles Procedure

pvary commented on pull request #2210:
URL: https://github.com/apache/iceberg/pull/2210#issuecomment-795119546


   > @pvary + @aokolnychyi Should be ready for another look if ya'll have time, Thanks in advance!
   
   LGTM on Hive related stuff. Only minors and mostly questions.
   When we start working on Hive migration definitely will move some of the code from the `SparkTableUtil`, `Spark3Util` to some more accessible place, but that's another story.
   Too much Spark code to be comfortable giving a +1.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org