You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "mcdull-zhang (via GitHub)" <gi...@apache.org> on 2024/06/18 09:45:00 UTC

[I] [VL] When the regexExpr of the split function is an empty character or a non-ASCII character, fall back to Valina Spark [incubator-gluten]

mcdull-zhang opened a new issue, #6127:
URL: https://github.com/apache/incubator-gluten/issues/6127

   ### Backend
   
   VL (Velox)
   
   ### Bug description
   
   **empty character**
   ```txt
   Expression:  split('abc','')
   Spark: ["a","b","c",""]
   Gluten: Reason: (0 vs. 1) split only supports only single-character pattern
   ```
   
   **non-ASCII character**
   ```txt
   Expression:  split('a,b,c',',')
   Spark: ["a","b","c"]
   Gluten: Reason: (3 vs. 1) split only supports only single-character pattern
   ```
   
   ### Spark version
   
   Spark-3.2.x
   
   ### Spark configurations
   
   _No response_
   
   ### System information
   
   _No response_
   
   ### Relevant logs
   
   ```bash
   java.lang.RuntimeException: Exception: VeloxRuntimeError
   Error Source: RUNTIME
   Error Code: INVALID_STATE
   Reason: (0 vs. 1) split only supports only single-character pattern
   Retriable: False
   Expression: patternString.size() == 1
   Context: split(n0_0, :VARCHAR)
   Top-Level Context: Same as context.
   Function: apply
   File: ep/build-velox/build/velox_ep/velox/functions/sparksql/SplitFunctions.cpp
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] [VL] When the regexExpr of the split function is an empty character or a non-ASCII character, fall back to Valina Spark [incubator-gluten]

Posted by "jackylee-ch (via GitHub)" <gi...@apache.org>.
jackylee-ch commented on issue #6127:
URL: https://github.com/apache/incubator-gluten/issues/6127#issuecomment-2175686757

   This is because the current split only supports splitting delemiter, while spark supports regexp. If necessary, I can add a PR to fix this problem, because Velox already supports [regexp_split](https://github.com/facebookincubator/velox/pull/10129).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] [VL] When the regexExpr of the split function is an empty character or a non-ASCII character, fall back to Valina Spark [incubator-gluten]

Posted by "gaoyangxiaozhu (via GitHub)" <gi...@apache.org>.
gaoyangxiaozhu commented on issue #6127:
URL: https://github.com/apache/incubator-gluten/issues/6127#issuecomment-2175908673

   > This is because the current split only supports splitting delemiter, while spark supports regexp. If necessary, I can add a PR to fix this problem, because Velox already supports [regexp_split](https://github.com/facebookincubator/velox/pull/10129).
   
   hey @jackylee-ch `regex_split` can't be used here since it not support `limit` parameter, please check my this Pr https://github.com/facebookincubator/velox/pull/10248


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] [VL] When the regexExpr of the split function is an empty character or a non-ASCII character, fall back to Valina Spark [incubator-gluten]

Posted by "mcdull-zhang (via GitHub)" <gi...@apache.org>.
mcdull-zhang commented on issue #6127:
URL: https://github.com/apache/incubator-gluten/issues/6127#issuecomment-2175711990

   @jackylee-ch   Please fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] [VL] When the regexExpr of the split function is an empty character or a non-ASCII character, fall back to Valina Spark [incubator-gluten]

Posted by "jackylee-ch (via GitHub)" <gi...@apache.org>.
jackylee-ch commented on issue #6127:
URL: https://github.com/apache/incubator-gluten/issues/6127#issuecomment-2176222382

   > hey @jackylee-ch `regex_split` can't be used here since it not support `limit` parameter, please check my this Pr [facebookincubator/velox#10248](https://github.com/facebookincubator/velox/pull/10248)
   
   Great job, wait for your fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] [VL] When the regexExpr of the split function is an empty character or a non-ASCII character, fall back to Valina Spark [incubator-gluten]

Posted by "gaoyangxiaozhu (via GitHub)" <gi...@apache.org>.
gaoyangxiaozhu commented on issue #6127:
URL: https://github.com/apache/incubator-gluten/issues/6127#issuecomment-2175906710

   hey @mcdull-zhang  i am working on fixing split issue, there is a fix PR in velox https://github.com/facebookincubator/velox/pull/10248, once the PR ready, i will update gluten part.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org