You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/17 11:43:14 UTC
[GitHub] [spark] yaooqinn commented on a change in pull request #26922:
[MINOR][SQL][DOC] Fix some ambiguous descriptions and format issue in
Dataset API Doc
yaooqinn commented on a change in pull request #26922: [MINOR][SQL][DOC] Fix some ambiguous descriptions and format issue in Dataset API Doc
URL: https://github.com/apache/spark/pull/26922#discussion_r358745360
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -2498,6 +2498,13 @@ class Dataset[T] private[sql](
*
* Use [[summary]] for expanded statistics and control over which statistics to compute.
*
+ * NOTES:
+ * - String columns are countable, so count is accurate
+ * - String columns are comparable, so min/max are accurate
Review comment:
yes, maybe I just over explained
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org