You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/13 10:20:18 UTC
[GitHub] [spark] dannymeijer opened a new pull request #31823: [SPARK-34630]Added typehint for pyspark.sql.Column.contains
dannymeijer opened a new pull request #31823:
URL: https://github.com/apache/spark/pull/31823
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR implements the missing typehints as per SPARK-34630.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To satisfy the aforementioned Jira ticket
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, just adding a missing typehint for Project Zen
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
No tests needed (just adding a typehint)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-799040105
**[Test build #136044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136044/testReport)** for PR 31823 at commit [`4c4b3e7`](https://github.com/apache/spark/commit/4c4b3e73ab4a2cdf84d038f23182b16f9b04b1c4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-805871502
Merged to master and branch-3.1.
Thank you @dannymeijer and @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #31823:
URL: https://github.com/apache/spark/pull/31823#discussion_r610719541
##########
File path: python/pyspark/sql/column.pyi
##########
@@ -115,3 +115,4 @@ class Column:
def over(self, window: WindowSpec) -> Column: ...
def __nonzero__(self) -> None: ...
def __bool__(self) -> None: ...
+ def contains(self, item: Union[str, Column]) -> Column: ...
Review comment:
The above typehint in version.pyi is ok to some reference like `pyspark.verion.__version`, but doesn't work on some reference like `pyspark.__version`, such like https://github.com/apache/spark/blob/c06758834e6192b1888b4a885c612a151588b390/python/pyspark/pandas/spark/accessors.py#L884
I submit a PR: https://github.com/apache/spark/pull/32110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31823: [SPARK-34630]Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31823:
URL: https://github.com/apache/spark/pull/31823#discussion_r593830911
##########
File path: python/pyspark/sql/column.pyi
##########
@@ -115,3 +115,4 @@ class Column:
def over(self, window: WindowSpec) -> Column: ...
def __nonzero__(self) -> None: ...
def __bool__(self) -> None: ...
+ def contains(self, item: Union[str, Column]) -> Column: ...
Review comment:
Can we also add the type hint for `__version__`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-805836645
@zero323, would be great if you find some time to take a look :-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-798117301
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-799900773
@zero323, would you like to try merging this as a brand new committer :-)? I think we can merge this to `master` branch and backport it to `branch-3.1` too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-805851798
Sorry, haven't seen your message @HyukjinKwon. On it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-799023647
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-799040105
**[Test build #136044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136044/testReport)** for PR 31823 at commit [`4c4b3e7`](https://github.com/apache/spark/commit/4c4b3e73ab4a2cdf84d038f23182b16f9b04b1c4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dannymeijer commented on pull request #31823: [PYTHON][SQL][SPARK-34630]Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
dannymeijer commented on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-798893806
> Thank you for your proposal @dannymeijer.
>
> I'd probably follow Scala side here and use `Any` here:
>
> ```python
> def contains(self, item: Any) -> Column: ...
> ```
>
> ‒ while it is not that useful, calls like
>
> ```
> >>> spark.range(1).select(lit("it is true").contains(True)).show()
> +--------------------------+
> |contains(it is true, true)|
> +--------------------------+
> | true|
> +--------------------------+
> ```
>
> or
>
> ```
> >>> spark.range(1).select(lit("it is true").contains(True)).show()
> +--------------------------+
> |contains(it is true, true)|
> +--------------------------+
> | true|
> +--------------------------+
> ```
>
> are technically speaking valid.
>
> Could you add `[PYTHON][SQL]` to the title?
Fair point! Changed it accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-799046058
**[Test build #136044 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136044/testReport)** for PR 31823 at commit [`4c4b3e7`](https://github.com/apache/spark/commit/4c4b3e73ab4a2cdf84d038f23182b16f9b04b1c4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 closed pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
zero323 closed pull request #31823:
URL: https://github.com/apache/spark/pull/31823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31823: [SPARK-34630]Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-798117301
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31823:
URL: https://github.com/apache/spark/pull/31823#issuecomment-799050167
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dannymeijer commented on a change in pull request #31823: [PYTHON][SQL][SPARK-34630]Added typehint for pyspark.sql.Column.contains
Posted by GitBox <gi...@apache.org>.
dannymeijer commented on a change in pull request #31823:
URL: https://github.com/apache/spark/pull/31823#discussion_r593884452
##########
File path: python/pyspark/sql/column.pyi
##########
@@ -115,3 +115,4 @@ class Column:
def over(self, window: WindowSpec) -> Column: ...
def __nonzero__(self) -> None: ...
def __bool__(self) -> None: ...
+ def contains(self, item: Union[str, Column]) -> Column: ...
Review comment:
Isn't __version__ already there?
https://github.com/apache/spark/blob/512f6258071666c3da07f6e6c6299d653a1cc370/python/pyspark/version.pyi#L19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org