You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "nielsbasjes (via GitHub)" <gi...@apache.org> on 2023/02/17 10:20:38 UTC
[GitHub] [avro] nielsbasjes opened a new pull request, #2106: AVRO-3715 Make the build work again.
nielsbasjes opened a new pull request, #2106:
URL: https://github.com/apache/avro/pull/2106
Fix python formatting problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] nielsbasjes merged pull request #2106: AVRO-3715 Make the build work again.
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes merged PR #2106:
URL: https://github.com/apache/avro/pull/2106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] nielsbasjes commented on pull request #2106: AVRO-3715 Make the build work again.
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on PR #2106:
URL: https://github.com/apache/avro/pull/2106#issuecomment-1434467668
@martin-g Can you please check if the type fix I did is correct. My python skills are too limited for me to know for sure if this is the correct way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] nielsbasjes commented on a diff in pull request #2106: AVRO-3715 Make the build work again.
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on code in PR #2106:
URL: https://github.com/apache/avro/pull/2106#discussion_r1109601424
##########
build.sh:
##########
@@ -42,7 +42,7 @@ change_java_version() {
# This might not have been sourced if the entrypoint is not bash
[[ -f "$HOME/.cargo/env" ]] && . "$HOME/.cargo/env"
-set -xe
+set -e
Review Comment:
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on a diff in pull request #2106: AVRO-3715 Make the build work again.
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #2106:
URL: https://github.com/apache/avro/pull/2106#discussion_r1109590611
##########
build.sh:
##########
@@ -42,7 +42,7 @@ change_java_version() {
# This might not have been sourced if the entrypoint is not bash
[[ -f "$HOME/.cargo/env" ]] && . "$HOME/.cargo/env"
-set -xe
+set -e
Review Comment:
I find `-x` useful for debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org