You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2020/09/28 07:38:00 UTC

[jira] [Commented] (CALCITE-4287) Fix the bug in checking aggregate input references in some rules

    [ https://issues.apache.org/jira/browse/CALCITE-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203060#comment-17203060 ] 

Julian Hyde commented on CALCITE-4287:
--------------------------------------

A bug is a problem. So a bug summary should never contain the word ‘fix’. It should describe the problem, not what you did to fix it. 

> Fix the bug in checking aggregate input references in some rules
> ----------------------------------------------------------------
>
>                 Key: CALCITE-4287
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4287
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Liya Fan
>            Assignee: Liya Fan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In some rules (e.g. {{AggregateJoinRemoveRule#onMatch)}}, the logic of checking if the aggregate references any columns from the other side is incorrect.
> For example, given an aggregate on a left join, the logic checks if the aggregate references any columns from the right side. If the aggregate happens to references the last column of the left input, the current implementation will make a wrong decision to skip the rule match.  
> This will miss opportunities of simplifying the plan. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)