You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by xiaoshuang-lu <gi...@git.apache.org> on 2017/12/01 11:43:01 UTC
[GitHub] httpcomponents-client pull request #89: add dropwizard metrics to httpclient
GitHub user xiaoshuang-lu opened a pull request:
https://github.com/apache/httpcomponents-client/pull/89
add dropwizard metrics to httpclient
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiaoshuang-lu/httpcomponents-client xiaoshuang-lu
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpcomponents-client/pull/89.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #89
----
commit 3c1018c025af99ca7b4ee725d7cfa3b7d043ee29
Author: Xiaoshuang LU <lu...@qiyi.com>
Date: 2017-12-01T11:34:17Z
add dropwizard metrics to httpclient
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@petermant @xiaoshuang-lu I also would prefer to have this PR closed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@xiaoshuang-lu No, I mean forcing all users to use one particular framework without any good reason.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by ryantxu <gi...@git.apache.org>.
Github user ryantxu commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
Isn't this already supported via:
http://metrics.dropwizard.io/3.2.3/manual/httpclient.html
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by xiaoshuang-lu <gi...@git.apache.org>.
Github user xiaoshuang-lu commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
It would be great if httpclient has the ability to collect critical metrics (requests-per-seconds, response-time, etc.) and dropwizard metrics provides what we want.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by xiaoshuang-lu <gi...@git.apache.org>.
Github user xiaoshuang-lu commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
Do you mean dependency conflicts? :-)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@xiaoshuang-lu We cannot just add an extra dependency to the stable (GA) release branch.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by xiaoshuang-lu <gi...@git.apache.org>.
Github user xiaoshuang-lu commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
All right, @ok2c. Which branch shall be used?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by petermant <gi...@git.apache.org>.
Github user petermant commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
Should this be closed? We have dependencies on httpclient 4.5.x as well as dropwizard 1.3.5, which uses metrics-core 4.0.2. Making httpclient dependent on metrics 3.2.5 risks incompatibilities if breaking API changes are made between 3.x and 4.x.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by xiaoshuang-lu <gi...@git.apache.org>.
Github user xiaoshuang-lu commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
ExecChainHandler means that one user need to implement the metrics collectors by self and another user need to do the same work too. These things are duplicated. From my perspective, users love the frameworks which are capable of native metric functionalities. Think about gRPC.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by xiaoshuang-lu <gi...@git.apache.org>.
Github user xiaoshuang-lu commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
Thanks, @ryantxu. I will investigate metrics-httpclient.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@xiaoshuang-lu Have you looked at the new 5.0 APIs, more specifically at the exec interceptors? If you find exec interceptors insufficient to collect all the requires metrics feel free to propose additional plug-in points, but please do not drag in a new dependency without a very good reason
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@xiaoshuang-lu I do not see gRPC require dropwizard
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@xiaoshuang-lu and what if I _want_ to use dropwizard?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by xiaoshuang-lu <gi...@git.apache.org>.
Github user xiaoshuang-lu commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@ok2c gRPC needs opencensus, something like dropwizard metrics.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-client issue #89: add dropwizard metrics to httpclient
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-client/pull/89
@xiaoshuang-lu master. I have a question, though. Why should HttpClient depend on dropwizard in the first place?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org