You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/01/12 01:25:18 UTC
Re: Review Request 55038: CMake: Stop searching for SVN and APR after
we've found them.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55038/#review161340
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Dec. 26, 2016, 1:53 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55038/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2016, 1:53 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently, the CMake build system employs scripts to find system
> installations of libsvn and libapr on Unix machines. These scripts will
> always repeat the search from scratch, independent of whether we've
> already searched for these libraries.
>
> This commit will cause these scripts to terminate early if we've already
> searched and found these libraries.
>
>
> Diffs
> -----
>
> 3rdparty/stout/cmake/FindApr.cmake 98adeabc19ac18a6519d72a43e7b7adeb68579de
> 3rdparty/stout/cmake/FindSvn.cmake e85e882db3b829e61e82945b056eb3cc7f2a803e
>
> Diff: https://reviews.apache.org/r/55038/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>