You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2014/11/05 05:48:49 UTC
[jira] [Commented] (THRIFT-2645) generated Go server code always
sets Success retval
[ https://issues.apache.org/jira/browse/THRIFT-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197516#comment-14197516 ]
Hudson commented on THRIFT-2645:
--------------------------------
SUCCESS: Integrated in Thrift #1331 (See [https://builds.apache.org/job/Thrift/1331/])
THRIFT-2645 generated Go server code always sets Success retval (jensg: rev b360ed393cc4845d9933d45dacbf0dd0446f0a88)
* compiler/cpp/src/generate/t_go_generator.cc
> generated Go server code always sets Success retval
> ---------------------------------------------------
>
> Key: THRIFT-2645
> URL: https://issues.apache.org/jira/browse/THRIFT-2645
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
> Affects Versions: 0.9.2
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Fix For: 0.9.2
>
> Attachments: THRIFT-2645_generated_Go_server_code_always_sets_Success_retval.patch
>
>
> I just recognized that the generated Go server code always sets the {{Success}} result value, even in case of an exception. This leads to problems with some clients, because the {{Success}} value is typically checked before the exception fields.
> Test case: Some tutorial clients report that "we can divide by 0", if run against the Go tutorial server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)