You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "jacktengg (via GitHub)" <gi...@apache.org> on 2023/12/25 10:27:10 UTC
[PR] [fix](hash join) fix column ref DCHECK failure of hash join node block mem reuse [doris]
jacktengg opened a new pull request, #28991:
URL: https://github.com/apache/doris/pull/28991
## Proposed changes
Introduced by #28851, after evaluating build side expr, some columns in resulting block may be referenced more than once in the same block.
e.g. `coalesce(col_a, 'string')` if `col_a` is nullable but actually contains no null values, in this case funcition `coalesce` will insert a new nullable column which references the original `col_a`.
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hash join) fix column ref DCHECK failure of hash join node block mem reuse [doris]
Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #28991:
URL: https://github.com/apache/doris/pull/28991#issuecomment-1868914907
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hash join) fix column ref DCHECK failure of hash join node block mem reuse [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28991:
URL: https://github.com/apache/doris/pull/28991#issuecomment-1868925688
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit c6fe4776dcd99b2fdc34d16bbcb1cc6fcf7cf125, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4877 4636 4619 4619
q2 379 146 168 146
q3 1514 1302 1270 1270
q4 1168 941 916 916
q5 3276 3263 3251 3251
q6 279 134 133 133
q7 1060 481 539 481
q8 2247 2308 2304 2304
q9 6853 6869 6829 6829
q10 3265 3306 3319 3306
q11 332 186 194 186
q12 391 213 205 205
q13 4631 3837 3775 3775
q14 242 219 213 213
q15 572 528 522 522
q16 449 382 384 382
q17 1014 573 505 505
q18 7135 6786 6786 6786
q19 1610 1440 1548 1440
q20 550 322 315 315
q21 3189 2768 2745 2745
q22 347 276 285 276
Total cold run time: 45380 ms
Total hot run time: 40605 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4580 4580 4557 4557
q2 300 170 171 170
q3 3567 3566 3555 3555
q4 2469 2451 2443 2443
q5 5811 5802 5804 5802
q6 267 121 126 121
q7 2410 1886 1831 1831
q8 3636 3656 3642 3642
q9 8988 8986 8962 8962
q10 3955 4079 4058 4058
q11 508 376 374 374
q12 790 597 589 589
q13 4328 3539 3549 3539
q14 294 264 253 253
q15 567 516 520 516
q16 493 444 482 444
q17 1969 1932 1957 1932
q18 8731 8190 8257 8190
q19 1853 1869 1838 1838
q20 2280 1956 1932 1932
q21 6711 6292 6285 6285
q22 503 421 413 413
Total cold run time: 65010 ms
Total hot run time: 61446 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hash join) fix column ref DCHECK failure of hash join node block mem reuse [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28991:
URL: https://github.com/apache/doris/pull/28991#issuecomment-1868929246
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.9 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 41.7 seconds inserted 10000000 Rows, about 239K ops/s
storage size: 17188513025 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hash join) fix column ref DCHECK failure of hash join node block mem reuse [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28991:
URL: https://github.com/apache/doris/pull/28991#issuecomment-1868999715
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hash join) fix column ref DCHECK failure of hash join node block mem reuse [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #28991:
URL: https://github.com/apache/doris/pull/28991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hash join) fix column ref DCHECK failure of hash join node block mem reuse [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28991:
URL: https://github.com/apache/doris/pull/28991#issuecomment-1868924117
TeamCity be ut coverage result:
Function Coverage: 36.57% (8552/23387)
Line Coverage: 28.64% (69531/242768)
Region Coverage: 27.64% (35956/130083)
Branch Coverage: 24.37% (18376/75414)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c6fe4776dcd99b2fdc34d16bbcb1cc6fcf7cf125_c6fe4776dcd99b2fdc34d16bbcb1cc6fcf7cf125/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hash join) fix column ref DCHECK failure of hash join node block mem reuse [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28991:
URL: https://github.com/apache/doris/pull/28991#issuecomment-1868917713
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hash join) fix column ref DCHECK failure of hash join node block mem reuse [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28991:
URL: https://github.com/apache/doris/pull/28991#issuecomment-1868917815
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hash join) fix column ref DCHECK failure of hash join node block mem reuse [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28991:
URL: https://github.com/apache/doris/pull/28991#issuecomment-1868999733
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org