You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by GitBox <gi...@apache.org> on 2021/04/10 15:49:11 UTC

[GitHub] [atlas] claudio-benfatto opened a new pull request #130: fix: fix python client api url concatenation

claudio-benfatto opened a new pull request #130:
URL: https://github.com/apache/atlas/pull/130


   Some of the python client api endpoints are currently broken as the result of the concatenation of the base url with the relative context path items.
   
   Specifically this happens for those path which contain a trailing forward slash (`/`), e.g.
   - https://github.com/apache/atlas/blob/master/intg/src/main/python/apache_atlas/client/entity.py#L61 and
   - https://github.com/apache/atlas/blob/master/intg/src/main/python/apache_atlas/client/entity.py#L58
   
   This produced requests of the kind:
   ```
   /api/atlas/v2/entity/uniqueAttribute/type//topic_schema
   ```
   which obviously resulted in errors.
   
   Instead of simply removing the `/` from the base paths I've chosen the approach of replacing the url concatenation method with a more robust one that handles leading and trailing slashes transparently.
   
   I did not find any tests for this module. If I'm wrong please let me know and I'll add/modify them.
   
   Regards!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [atlas] nixonrodrigues commented on pull request #130: fix: fix python client api url concatenation

Posted by GitBox <gi...@apache.org>.

nixonrodrigues commented on pull request #130:
URL: https://github.com/apache/atlas/pull/130#issuecomment-852188764


   +1 for the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [atlas] nixonrodrigues merged pull request #130: ATLAS-4318 : fix python client api url concatenation

Posted by GitBox <gi...@apache.org>.

nixonrodrigues merged pull request #130:
URL: https://github.com/apache/atlas/pull/130


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org