[jira] [Commented] (TEZ-3177) Non-DAG events should use the session domain or no domain if the data does not need protection

["Siddharth Seth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223051#comment-15223051 ] 

Siddharth Seth commented on TEZ-3177:
-------------------------------------

{code}
+      if (historyACLPolicyManager != null
+          && sessionDomainId != null && !sessionDomainId.isEmpty()
+          && domainId != null && !domainId.isEmpty()) {
+        if (HistoryEventType.isDAGSpecificEvent(event.getHistoryEvent().getEventType())) {
           historyACLPolicyManager.updateTimelineEntityDomain(entities[i], domainId);
+        } else {
+          historyACLPolicyManager.updateTimelineEntityDomain(entities[i], sessionDomainId);
         }
{code}

Dag specific domain id / session domain id - will both either be set, or unset ? Do wen end up missing the domainId in some cases if both are unset. It may be better to flip the check to say - if(dagDomainType) - null check the dagDomainId, otherwise null check the sessionDomainId.

Rest looks good.


> Non-DAG events should use the session domain or no domain if the data does not need protection 
> -----------------------------------------------------------------------------------------------
>
>                 Key: TEZ-3177
>                 URL: https://issues.apache.org/jira/browse/TEZ-3177
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>         Attachments: TEZ-3177.1.patch
>
>
> There have been issues noticed where when using dag specific domains, container events get generated under different dags causing issues as they are updated using different domains. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)