[jira] Commented: (HBASE-2062) Metrics documentation outdated

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793297#action_12793297 ] 

stack commented on HBASE-2062:
------------------------------

+1 on patch.  Looks good to me.  I'm good too w/ moving env variable to HBASE_JMX_OPTS.

> Metrics documentation outdated
> ------------------------------
>
>                 Key: HBASE-2062
>                 URL: https://issues.apache.org/jira/browse/HBASE-2062
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 0.20.1, 0.20.2
>            Reporter: Lars George
>            Assignee: Lars George
>            Priority: Trivial
>             Fix For: 0.20.3
>
>         Attachments: HBASE-2062-trunk.patch, HBASE-2062.patch
>
>
> HBASE-1687 fixes this supposedly but during the update of the metrics.xml there seemed to be a missed deletion of the last section describing the now obsolete OPTS addition. Especially see [this note|https://issues.apache.org/jira/browse/HBASE-1687?focusedCommentId=12754381&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12754381]. Trivial fix by copying the version from trunk over.
> I would also ask if we could change JMX_OPTS to HBASE_JMX_OPTS to be in line with other variables and when using this together with Edward's [scripts|http://www.jointhegrid.com/svn/hadoop-cacti-jtg/trunk/doc/INSTALL.txt] who uses HADOOP_JMX_BASE. I asked Edward if he would be OK changing it to the matching HADOOP_JMX_OPTS. I also asked him to remove the copied section about editing the "hbase" start script in versions 0.20.1 or later. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.