You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2017/08/31 09:31:39 UTC
[GitHub] storm pull request #2303: STORM-2660 The Nimbus storm-local directory is rel...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2303
STORM-2660 The Nimbus storm-local directory is relative to the workin…
…g directory of the shell executing "storm nimbus"
* Let Nimbus uses same storm-local directory as Supervisor which is known to be valid
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2660
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2303
----
commit b30fb2764525cdd223159e6f01d980af9ec3eb6a
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2017-08-31T09:26:59Z
STORM-2660 The Nimbus storm-local directory is relative to the working directory of the shell executing "storm nimbus"
* Let Nimbus uses same storm-local directory as Supervisor which is known to be valid
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2303: STORM-2660 The Nimbus storm-local directory is rel...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2303#discussion_r136595401
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -215,6 +215,20 @@ public static String absoluteStormLocalDir(Map<String, Object> conf) {
}
}
+ public static String absoluteStormBlobStoreDir(Map<String, Object> conf) {
+ String stormHome = System.getProperty("storm.home");
+ String blobStoreDir = (String) conf.get(Config.BLOBSTORE_DIR);
+ if (blobStoreDir == null) {
+ return null;
--- End diff --
I think we can make this a little nicer by having this return absoluteStormLocalDir. There's less risk of us accidentally forgetting to null check the result if this ever gets used elsewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2303: STORM-2660 The Nimbus storm-local directory is relative t...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2303
+1, thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2303: STORM-2660 The Nimbus storm-local directory is relative t...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2303
Nice finding @srdo . Addressed other places as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2303: STORM-2660 The Nimbus storm-local directory is relative t...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2303
@srdo Also addressed review comments and squashed commits into one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2303: STORM-2660 The Nimbus storm-local directory is relative t...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2303
+1, verified that `storm nimbus` now puts storm-local in the right directory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2303: STORM-2660 The Nimbus storm-local directory is relative t...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2303
Thanks for taking a look at this. The fix looks good, but I think this is an issue elsewhere too. At least this path is making the same mistake https://github.com/apache/storm/blob/85486dde9dc5cff8e9a7cbb7c913c5cb68ed3be5/storm-server/src/main/java/org/apache/storm/blobstore/LocalFsBlobStore.java#L90.
Looking at uses of STORM_LOCAL_DIR, I'm wondering if these uses are also suspicious:
* https://github.com/apache/storm/blob/a4afacd9617d620f50cf026fc599821f7ac25c79/storm-core/src/jvm/org/apache/storm/command/KillWorkers.java#L31
*https://github.com/apache/storm/blob/e1dd247ce97ad560c72554ed612e1ec8e69e9777/storm-server/src/main/java/org/apache/storm/scheduler/utils/ArtifactoryConfigLoader.java#L335
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2303: STORM-2660 The Nimbus storm-local directory is rel...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2303
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---