You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by ilooner <gi...@git.apache.org> on 2017/11/22 20:41:38 UTC

[GitHub] drill pull request #1048: DRILL-5987: Use one version of javassist

GitHub user ilooner opened a pull request:

    https://github.com/apache/drill/pull/1048

    DRILL-5987: Use one version of javassist

    There were two different versions of javassist being pulled in by **msgpack** and **reflections**. This makes sure only one version is included.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ilooner/drill DRILL-5987

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1048.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1048
    
----
commit 23e82f4c73afbad66cab110dd06c672adcea6984
Author: Timothy Farkas <ti...@apache.org>
Date:   2017-11-22T20:31:18Z

    DRILL-5987: Use one version of javassist

----


---

[GitHub] drill issue #1048: DRILL-5987: Use one version of javassist

Posted by ilooner <gi...@git.apache.org>.

Github user ilooner commented on the issue:

    https://github.com/apache/drill/pull/1048
  
    @arina-ielchiieva 


---

[GitHub] drill issue #1048: DRILL-5987: Use one version of javassist

Posted by arina-ielchiieva <gi...@git.apache.org>.

Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/1048
  
    +1, LGTM.


---

[GitHub] drill pull request #1048: DRILL-5987: Use one version of javassist

Posted by vrozov <gi...@git.apache.org>.

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1048#discussion_r152690825
  
    --- Diff: common/pom.xml ---
    @@ -63,12 +63,29 @@
           <groupId>org.msgpack</groupId>
           <artifactId>msgpack</artifactId>
           <version>0.6.6</version>
    +      <exclusions>
    --- End diff --
    
    Exclusions should not be necessary.


---

[GitHub] drill pull request #1048: DRILL-5987: Use one version of javassist

Posted by ilooner <gi...@git.apache.org>.

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1048#discussion_r152703332
  
    --- Diff: common/pom.xml ---
    @@ -63,12 +63,29 @@
           <groupId>org.msgpack</groupId>
           <artifactId>msgpack</artifactId>
           <version>0.6.6</version>
    +      <exclusions>
    --- End diff --
    
    Removed exclusion for msgpack. The exclusion of javassist for reflections is necessary because before javassist version 3.13 the groupId was **javassist** after version 3.13 the groupId of javassist was changed to **org.javassist**. I also noticed ./logical/pom.xml declared the same msgpack and reflections dependencies as drill common. So I removed the redundant dependency declaration and also made msgpack and reflections managed dependencies.


---

[GitHub] drill pull request #1048: DRILL-5987: Use one version of javassist

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/1048


---