You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2016/11/14 12:18:07 UTC
[GitHub] brooklyn-server pull request #433: Fix dependency URI path for downstream pr...
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/433
Fix dependency URI path for downstream projects + Karaf feature verification
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-server fix/karaf-dependency
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/433.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #433
----
commit 8960aab0f11cd7d1983f85d7c0be14e6e9bcc988
Author: Thomas Bouron <th...@cloudsoftcorp.com>
Date: 2016-11-14T12:17:05Z
Fix dependency URI path for downstream projects + Karaf feature verification
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #433: Fix dependency URI path for downstream projects ...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/433
I understand that this has been confirmed manually with a mvn build, checking in karaf that okhttp bundle was added correctly. Therefore merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #433: Fix dependency URI path for downstream pr...
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/433#discussion_r87794702
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -256,7 +256,7 @@
https://github.com/square/okhttp/pull/2246
-->
<!-- TODO use ServiceMix bundle for okhttp when dependency on okio is fixed there -->
- <bundle dependency="true">wrap:mvn:com.squareup.okhttp/okhttp/2.2.0$Import-Package=org.apache.http.*;resolution:=optional,android.util.*;resolution:=optional,okio;version="[1.2.0, 1.3.0)",*</bundle>
+ <bundle dependency="true">wrap:mvn:com.squareup.okhttp/okhttp/2.2.0$Import-Package=org.apache.http.*;resolution:=optional,android.util.*;resolution:=optional,okio;version=%27[1.2.0,1.3.0)%27,*</bundle>
--- End diff --
Tested with encoded double quotes (`%22`) but the feature verification was still failing. Not sure why unfortunately
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #433: Fix dependency URI path for downstream pr...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/433#discussion_r87794146
--- Diff: karaf/features/src/main/feature/feature.xml ---
@@ -256,7 +256,7 @@
https://github.com/square/okhttp/pull/2246
-->
<!-- TODO use ServiceMix bundle for okhttp when dependency on okio is fixed there -->
- <bundle dependency="true">wrap:mvn:com.squareup.okhttp/okhttp/2.2.0$Import-Package=org.apache.http.*;resolution:=optional,android.util.*;resolution:=optional,okio;version="[1.2.0, 1.3.0)",*</bundle>
+ <bundle dependency="true">wrap:mvn:com.squareup.okhttp/okhttp/2.2.0$Import-Package=org.apache.http.*;resolution:=optional,android.util.*;resolution:=optional,okio;version=%27[1.2.0,1.3.0)%27,*</bundle>
--- End diff --
@tbouron Why did you go for single quotes rather than double quotes (`%22`), out of interest?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #433: Fix dependency URI path for downstream pr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #433: Fix dependency URI path for downstream projects ...
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/433
For some reason, the official maven karaf plugin cannot verify this feature if the quotes are not single quotes AND properly URI encoded, hence the `%27`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---