You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/31 12:24:56 UTC

[GitHub] [pulsar] dragonls opened a new pull request #14971: [broker] Add ThresholdLoadManagerStrategy for load balancer load manager.

dragonls opened a new pull request #14971:
URL: https://github.com/apache/pulsar/pull/14971


   ### Motivation
   
   If using `loadBalancerLoadSheddingStrategy=org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder`, the unloaded bundles might be loaded by another broker which has resource usage above average load, and make the new broker be overloaded or some other bundles of the broker will be shed.
   
   It could be much better to select the broker based on which one has resource usage below average load.
   
   ### Modifications
   - Add `loadBalancerLoadManagerStrategy` conf to support choose the load manager strategy
   - Add `org.apache.pulsar.broker.loadbalance.impl.ThresholdLoadManagerStrategy`
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
     - Add test `org.apache.pulsar.broker.loadbalance.ModularLoadManagerStrategyTest#testThresholdLoadManagerStrategy`
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   - [ ] `no-need-doc` 
   - [ ] `doc` 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dragonls commented on pull request #14971: [feature][broker] Add new load manager strategy for load manager to select broker having load below average.

Posted by GitBox <gi...@apache.org>.
dragonls commented on pull request #14971:
URL: https://github.com/apache/pulsar/pull/14971#issuecomment-1086623504


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14971: [broker] Add ThresholdLoadManagerStrategy for load balancer load manager.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14971:
URL: https://github.com/apache/pulsar/pull/14971#issuecomment-1084693711


   @dragonls:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14971: [broker] Add ThresholdLoadManagerStrategy for load balancer load manager.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14971:
URL: https://github.com/apache/pulsar/pull/14971#issuecomment-1084685757


   @dragonls:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on pull request #14971: [broker] Add ThresholdLoadManagerStrategy for load balancer load manager.

Posted by GitBox <gi...@apache.org>.
HQebupt commented on pull request #14971:
URL: https://github.com/apache/pulsar/pull/14971#issuecomment-1086587616


   Thank your contribution. Please refer the [PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dragonls commented on pull request #14971: [feature][broker] Add new load manager strategy for load manager to select broker having load below average.

Posted by GitBox <gi...@apache.org>.
dragonls commented on pull request #14971:
URL: https://github.com/apache/pulsar/pull/14971#issuecomment-1086623466


   > Thank your contribution. Please refer the [PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35).
   
   Thanks for guiding. Updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dragonls commented on pull request #14971: [broker] Add ThresholdLoadManagerStrategy for load balancer load manager.

Posted by GitBox <gi...@apache.org>.
dragonls commented on pull request #14971:
URL: https://github.com/apache/pulsar/pull/14971#issuecomment-1085472959


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] dragonls commented on pull request #14971: [broker] Add ThresholdLoadManagerStrategy for load balancer load manager.

Posted by GitBox <gi...@apache.org>.
dragonls commented on pull request #14971:
URL: https://github.com/apache/pulsar/pull/14971#issuecomment-1085556444


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org