You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/04 12:58:24 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3929: server:
fix vm migration failed if iso is attached
ustcweizhou opened a new pull request #3929: server: fix vm migration failed if iso is attached
URL: https://github.com/apache/cloudstack/pull/3929
## Description
<!--- Describe your changes in detail -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
If vm has attached ISO, the migration fails with error message "org.libvirt.LibvirtException: Cannot access storage file /mnt/b33e5a1d-e4ea-3465-b6ac-c98dc8ff8af0/207-2-cc5fd717-2d57-3bb3-bcf6-2c930268db6c.iso"
This issue happens after #2983 is merged.
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
create vm
register ISO
attach ISO to vm
migrate vm
all work fine.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3929: server: fix vm
migration failed if iso is attached
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3929: server: fix vm migration failed if iso is attached
URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-595112266
@rhtyd @nvazquez I will close this PR ,and test #3935
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3929: server: fix vm
migration failed if iso is attached
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3929: server: fix vm migration failed if iso is attached
URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594636554
> Hi @ustcweizhou, I've also provided a fix within this PR: #3828, specifically this commit: [2102864](https://github.com/apache/cloudstack/commit/2102864e8a57ae39a71d4839928923e43554bdff)
>
> prepareIso() will select the ISO from primary or secondary storage depending if the template is direct download or not
@nvazquez it looks better. can you create a separated pull request for it ? we need to fix the issue asap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3929: server: fix vm
migration failed if iso is attached
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3929: server: fix vm migration failed if iso is attached
URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594595307
Hi @ustcweizhou, I've also provided a fix within this PR: #3828, specifically this commit: https://github.com/apache/cloudstack/pull/3828/commits/2102864e8a57ae39a71d4839928923e43554bdff
prepareIso will select the ISO from primary or secondary storage depending if the template is direct download or not
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez edited a comment on issue #3929: server: fix
vm migration failed if iso is attached
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on issue #3929: server: fix vm migration failed if iso is attached
URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594595307
Hi @ustcweizhou, I've also provided a fix within this PR: #3828, specifically this commit: https://github.com/apache/cloudstack/pull/3828/commits/2102864e8a57ae39a71d4839928923e43554bdff
prepareIso() will select the ISO from primary or secondary storage depending if the template is direct download or not
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3929: server: fix vm
migration failed if iso is attached
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3929: server: fix vm migration failed if iso is attached
URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594547702
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3929: server: fix vm
migration failed if iso is attached
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3929: server: fix vm migration failed if iso is attached
URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-595028893
Sure @ustcweizhou please see #3935
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3929: server: fix vm
migration failed if iso is attached
Posted by GitBox <gi...@apache.org>.
ustcweizhou commented on issue #3929: server: fix vm migration failed if iso is attached
URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594506161
@nvazquez could you please review/test it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache closed pull request #3929: server: fix
vm migration failed if iso is attached
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #3929: server: fix vm migration failed if iso is attached
URL: https://github.com/apache/cloudstack/pull/3929
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3929: server: fix vm
migration failed if iso is attached
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3929: server: fix vm migration failed if iso is attached
URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-595056656
@ustcweizhou @nvazquez can you advice which one of the PRs to keep, this or Nicolas's #3935 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3929: server: fix vm
migration failed if iso is attached
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3929: server: fix vm migration failed if iso is attached
URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594547609
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3929: server: fix vm
migration failed if iso is attached
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3929: server: fix vm migration failed if iso is attached
URL: https://github.com/apache/cloudstack/pull/3929#issuecomment-594559801
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services