You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by su...@apache.org on 2020/07/17 11:39:12 UTC
[incubator-echarts] 13/16: fix: fix noTarget logic for dataZoom.
This is an automated email from the ASF dual-hosted git repository.
sushuang pushed a commit to branch remove-component
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit c4d442eb596e71c5e84cc622805db2997066fc7a
Author: 100pah <su...@gmail.com>
AuthorDate: Thu Jul 16 19:13:39 2020 +0800
fix: fix noTarget logic for dataZoom.
---
src/component/dataZoom/DataZoomModel.ts | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/component/dataZoom/DataZoomModel.ts b/src/component/dataZoom/DataZoomModel.ts
index 38aa4e7..6212aa2 100644
--- a/src/component/dataZoom/DataZoomModel.ts
+++ b/src/component/dataZoom/DataZoomModel.ts
@@ -171,7 +171,7 @@ class DataZoomModel<Opts extends DataZoomOption = DataZoomOption> extends Compon
private _targetAxisInfoMap: DataZoomTargetAxisInfoMap;
- private _noTarget: boolean;
+ private _noTarget: boolean = true;
/**
* It is `[rangeModeForMin, rangeModeForMax]`.
@@ -278,7 +278,12 @@ class DataZoomModel<Opts extends DataZoomOption = DataZoomOption> extends Compon
this._fillAutoTargetAxisByOrient(targetAxisIndexMap, this._orient);
}
- this._noTarget = !targetAxisIndexMap.keys().length;
+ this._noTarget = true;
+ targetAxisIndexMap.each(function (axisInfo) {
+ if (axisInfo.indexList.length) {
+ this._noTarget = false;
+ }
+ }, this);
}
private _fillSpecifiedTargetAxis(targetAxisIndexMap: DataZoomTargetAxisInfoMap): boolean {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org