[GitHub] [solr] col-panic commented on a diff in pull request #890: SOLR-16230: JWT nested roles support

[GitBox <gi...@apache.org>]

col-panic commented on code in PR #890:
URL: https://github.com/apache/solr/pull/890#discussion_r888388313


##########
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##########
@@ -595,7 +595,20 @@ protected JWTAuthenticationResponse authenticate(String authorizationHeader) {
             } else {
               // Pull roles from separate claim, either as whitespace separated list or as JSON
               // array
-              Object rolesObj = jwtClaims.getClaimValue(rolesClaim);
+              Object rolesObj = null;
+              if (rolesClaim.contains(".")) {
+                // support map resolution of nested values
+                String[] nestedKeys = rolesClaim.split("\\.");

Review Comment:
   @sonatype-lift ignore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org