You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/03 01:46:40 UTC

[GitHub] [pulsar] fantapsody opened a new pull request #10468: Fix the AlreadyClosedException used in leader election

fantapsody opened a new pull request #10468:
URL: https://github.com/apache/pulsar/pull/10468


   ### Motivation
   
   From the context, it looks to me that the exception thrown in the line https://github.com/apache/pulsar/blob/2a522c85c0add3f1f647befb0a560689324114bd/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/LeaderElectionImpl.java#L163 should be an `org.apache.pulsar.metadata.api.MetadataStoreException.AlreadyClosedException` rather than an `org.apache.pulsar.client.api.PulsarClientException.AlreadyClosedException`.
   
   ### Modifications
   
   Change the `AlreadyClosedException` that imported.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   **This change is a trivial rework / code cleanup without any test coverage.**
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] eolivelli merged pull request #10468: Fix the AlreadyClosedException used in leader election

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10468:
URL: https://github.com/apache/pulsar/pull/10468


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] eolivelli commented on pull request #10468: Fix the AlreadyClosedException used in leader election

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10468:
URL: https://github.com/apache/pulsar/pull/10468#issuecomment-831024221


   Committed to master branch, thank you @fantapsody 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org