You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Gregory Chanan <gc...@cloudera.com> on 2013/10/17 03:41:55 UTC
Review Request 14705: SENTRY-43: Refactor into policy specific modules
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14705/
-----------------------------------------------------------
Review request for sentry and Shreepadma Venugopalan.
Bugs: SENTRY-43
https://issues.apache.org/jira/browse/SENTRY-43
Repository: sentry
Description
-------
1) sentry-provider-policy-db now sentry-policy-db
2) sentry-provider-policy-search now sentry-policy-search
3) moved provider-related classes {AuthorizationProvider, NoAuthorizationProvider} from core-common to sentry-provider-common
4) moved provider-related classes {RoleValidator, PermissionFactory, PolicyEngine} from sentry-provider-common to sentry-policy-common
Diffs
-----
pom.xml a713c41
sentry-binding/sentry-binding-hive/pom.xml 2b09a47
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java d0ec4de
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java 7df12a6
sentry-binding/sentry-binding-solr/pom.xml PRE-CREATION
sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java PRE-CREATION
sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/conf/SolrAuthzConf.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizationProvider.java 0239f12
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/NoAuthorizationProvider.java 3bcd08b
sentry-dist/pom.xml 895b03c
sentry-dist/src/main/assembly/src.xml 91f5696
sentry-policy/sentry-policy-common/pom.xml PRE-CREATION
sentry-provider/pom.xml 2a16800
sentry-provider/sentry-provider-common/pom.xml f7be9dd
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/PermissionFactory.java 5e7c7dd
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/PolicyEngine.java ce0ea26
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ProviderBackend.java 32ac8b2
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/RoleValidator.java efd44f1
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/HadoopGroupResourceAuthorizationProvider.java 24c0a5a
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/LocalGroupResourceAuthorizationProvider.java 96f260e
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/ResourceAuthorizationProvider.java 4e12b70
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/SimpleFileProviderBackend.java 373050e
sentry-provider/sentry-provider-policy-db/pom.xml 2245d75
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/AbstractDBRoleValidator.java 3f8241b
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBModelAuthorizables.java c454831
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBWildcardPermission.java 1270fb2
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseMustMatch.java adfd2a3
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseRequiredInRole.java c85807d
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServerNameMustMatch.java 577f71f
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServersAllIsInvalid.java be33830
sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/SimpleDBPolicyEngine.java 1a56798
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/AbstractTestSimplePolicyEngine.java 2c2e960
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/DBPolicyFileBackend.java 383db0b
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBModelAuthorizables.java 0058d71
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBWildcardPermission.java 10b93de
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDatabaseRequiredInRole.java c957473
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestPolicyParsingNegative.java c55fbeb
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderGeneralCases.java 0b3268d
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderSpecialCases.java 9187be3
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestSimpleDBPolicyEngineDFS.java 47e2b87
sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestSimpleDBPolicyEngineLocalFS.java fb2bc24
sentry-provider/sentry-provider-policy-db/src/test/resources/log4j.properties
sentry-provider/sentry-provider-policy-db/src/test/resources/test-authz-provider-other-group.ini
sentry-provider/sentry-provider-policy-db/src/test/resources/test-authz-provider.ini
sentry-provider/sentry-provider-policy-search/pom.xml 80db002
sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/AbstractSearchRoleValidator.java 307d79e
sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/CollectionRequiredInRole.java c803a81
sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/SearchModelAuthorizables.java 41917a6
sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/SearchWildcardPermission.java ed76fe1
sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/SimpleSearchPolicyEngine.java 7d37660
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/AbstractTestSearchPolicyEngine.java 0583a51
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/SearchPolicyFileBackend.java db331ab
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestCollectionRequiredInRole.java 0055250
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchAuthorizationProviderGeneralCases.java 8a5e697
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchAuthorizationProviderSpecialCases.java 0163275
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchModelAuthorizables.java a79d9df
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchPolicyEngineDFS.java a17c82f
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchPolicyEngineLocalFS.java d85051b
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchPolicyNegative.java 665591a
sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchWildcardPermission.java d43854d
sentry-provider/sentry-provider-policy-search/src/test/resources/log4j.properties
sentry-provider/sentry-provider-policy-search/src/test/resources/test-authz-provider.ini
sentry-tests/sentry-tests-hive/pom.xml 0941cf7
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java cc1243c
Diff: https://reviews.apache.org/r/14705/diff/
Testing
-------
Ran the unit tests successfully.
Thanks,
Gregory Chanan
Re: Review Request 14705: SENTRY-43: Refactor into policy specific modules
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14705/#review27262
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On Oct. 17, 2013, 1:41 a.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14705/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2013, 1:41 a.m.)
>
>
> Review request for sentry and Shreepadma Venugopalan.
>
>
> Bugs: SENTRY-43
> https://issues.apache.org/jira/browse/SENTRY-43
>
>
> Repository: sentry
>
>
> Description
> -------
>
> 1) sentry-provider-policy-db now sentry-policy-db
> 2) sentry-provider-policy-search now sentry-policy-search
> 3) moved provider-related classes {AuthorizationProvider, NoAuthorizationProvider} from core-common to sentry-provider-common
> 4) moved provider-related classes {RoleValidator, PermissionFactory, PolicyEngine} from sentry-provider-common to sentry-policy-common
>
>
> Diffs
> -----
>
> pom.xml a713c41
> sentry-binding/sentry-binding-hive/pom.xml 2b09a47
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java d0ec4de
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java 7df12a6
> sentry-binding/sentry-binding-solr/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java PRE-CREATION
> sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/conf/SolrAuthzConf.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/AuthorizationProvider.java 0239f12
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/NoAuthorizationProvider.java 3bcd08b
> sentry-dist/pom.xml 895b03c
> sentry-dist/src/main/assembly/src.xml 91f5696
> sentry-policy/sentry-policy-common/pom.xml PRE-CREATION
> sentry-provider/pom.xml 2a16800
> sentry-provider/sentry-provider-common/pom.xml f7be9dd
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/PermissionFactory.java 5e7c7dd
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/PolicyEngine.java ce0ea26
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ProviderBackend.java 32ac8b2
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/RoleValidator.java efd44f1
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/HadoopGroupResourceAuthorizationProvider.java 24c0a5a
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/LocalGroupResourceAuthorizationProvider.java 96f260e
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/ResourceAuthorizationProvider.java 4e12b70
> sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/SimpleFileProviderBackend.java 373050e
> sentry-provider/sentry-provider-policy-db/pom.xml 2245d75
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/AbstractDBRoleValidator.java 3f8241b
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBModelAuthorizables.java c454831
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DBWildcardPermission.java 1270fb2
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseMustMatch.java adfd2a3
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/DatabaseRequiredInRole.java c85807d
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServerNameMustMatch.java 577f71f
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/ServersAllIsInvalid.java be33830
> sentry-provider/sentry-provider-policy-db/src/main/java/org/apache/sentry/provider/db/SimpleDBPolicyEngine.java 1a56798
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/AbstractTestSimplePolicyEngine.java 2c2e960
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/DBPolicyFileBackend.java 383db0b
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBModelAuthorizables.java 0058d71
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDBWildcardPermission.java 10b93de
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestDatabaseRequiredInRole.java c957473
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestPolicyParsingNegative.java c55fbeb
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderGeneralCases.java 0b3268d
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestResourceAuthorizationProviderSpecialCases.java 9187be3
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestSimpleDBPolicyEngineDFS.java 47e2b87
> sentry-provider/sentry-provider-policy-db/src/test/java/org/apache/sentry/provider/db/TestSimpleDBPolicyEngineLocalFS.java fb2bc24
> sentry-provider/sentry-provider-policy-db/src/test/resources/log4j.properties
> sentry-provider/sentry-provider-policy-db/src/test/resources/test-authz-provider-other-group.ini
> sentry-provider/sentry-provider-policy-db/src/test/resources/test-authz-provider.ini
> sentry-provider/sentry-provider-policy-search/pom.xml 80db002
> sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/AbstractSearchRoleValidator.java 307d79e
> sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/CollectionRequiredInRole.java c803a81
> sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/SearchModelAuthorizables.java 41917a6
> sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/SearchWildcardPermission.java ed76fe1
> sentry-provider/sentry-provider-policy-search/src/main/java/org/apache/sentry/provider/search/SimpleSearchPolicyEngine.java 7d37660
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/AbstractTestSearchPolicyEngine.java 0583a51
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/SearchPolicyFileBackend.java db331ab
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestCollectionRequiredInRole.java 0055250
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchAuthorizationProviderGeneralCases.java 8a5e697
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchAuthorizationProviderSpecialCases.java 0163275
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchModelAuthorizables.java a79d9df
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchPolicyEngineDFS.java a17c82f
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchPolicyEngineLocalFS.java d85051b
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchPolicyNegative.java 665591a
> sentry-provider/sentry-provider-policy-search/src/test/java/org/apache/sentry/provider/search/TestSearchWildcardPermission.java d43854d
> sentry-provider/sentry-provider-policy-search/src/test/resources/log4j.properties
> sentry-provider/sentry-provider-policy-search/src/test/resources/test-authz-provider.ini
> sentry-tests/sentry-tests-hive/pom.xml 0941cf7
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java cc1243c
>
> Diff: https://reviews.apache.org/r/14705/diff/
>
>
> Testing
> -------
>
> Ran the unit tests successfully.
>
>
> Thanks,
>
> Gregory Chanan
>
>