[GitHub] [flink] dianfu commented on a change in pull request #11656: [FLINK-16983][python] Support RowType in vectorized Python UDF

[GitBox <gi...@apache.org>]

dianfu commented on a change in pull request #11656: [FLINK-16983][python] Support RowType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11656#discussion_r406629141
 
 

 ##########
 File path: flink-python/pyflink/table/tests/test_pandas_udf.py
 ##########
 @@ -165,6 +165,12 @@ def nested_array_func(nested_array_param):
                 'nested_array_param of wrong type %s !' % type(nested_array_param[0])
             return pd.Series(nested_array_param[0])
 
+        def row_func(row_param):
+            assert isinstance(row_param, pd.Series)
+            assert isinstance(row_param[0], dict), \
 
 Review comment:
   I think this will be handled internally by Arrow, e.g. it could identify the order of the columns according to the field names and so I think there is no order problems. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services