You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/09/05 12:30:12 UTC
[jira] [Commented] (HBASE-4313) Refactor TestHBaseFsck to make
adding individual hbck tests easier
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097114#comment-13097114 ]
jiraposter@reviews.apache.org commented on HBASE-4313:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1713/
-----------------------------------------------------------
Review request for hbase, Todd Lipcon and Michael Stack.
Summary
-------
This is a mostly semantics preserving patch. This will make HBASE-3354 easier to do. Trunk based version of patch to follow.
commit 6712c70b524bedf6a5e4999d4d2203373b0f1772
Author: Jonathan Hsieh <jo...@cloudera.com>
Date: Thu Aug 25 00:10:27 2011 -0700
HBASE-4313 Refactor TestHBaseFsck to make adding hbck tests easier
- Cleanup table creation
- Add proper MiniCluster shutdown
- Separate each corruption into a separate test
This addresses bug HBASE-4313.
https://issues.apache.org/jira/browse/HBASE-4313
Diffs
-----
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 1c766b3
Diff: https://reviews.apache.org/r/1713/diff
Testing
-------
tests pass.
Thanks,
jmhsieh
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira