[GitHub] Maxwell2022 commented on issue #978: redirects change https requests to http locations

[GitBox <gi...@apache.org>]

Maxwell2022 commented on issue #978: redirects change https requests to http locations
URL: https://github.com/apache/incubator-superset/issues/978#issuecomment-384560057
 
 
   @mistercrunch Can we actually re-open it? I'm using the latest `0.24.0` within docker (https://github.com/amancevice/superset). In front of this container, I have nginx where my SSL certificate is installed.
   
   Everything is working fine, except that I have superset in an Iframe, and that as soon as the user login, it gets redirected to HTTP and the browser doesn't like it...
   
   Here is the call I'm making to the login page with the user being login already, and how it gets redirected back an forth:
   
   ```
   => `https://superset.example.com/login/` 
   -> `http://superset.example.com (301)` 
   -> `https://superset.example.com (302)`  
   -> `http://superset.example.com/welcome/ (301)` 
   -> `https://superset.example.com/welcome/ (302)`
   ```
   
   The `301` is happening because I have a rule in nginx to force HTTPS. However the issue is with the application [`redirect()`](https://github.com/apache/incubator-superset/blob/fd84fd89ce12388d4aa4c98bc3d0d1257d355168/superset/__init__.py#L152)
   
   I tried all the config variables listed here, but still nothing:
   
   ```
   ENABLE_PROXY_FIX = True
   PREFERRED_URL_SCHEME = 'https'
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services