You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/05 07:15:13 UTC

[GitHub] apeforest commented on a change in pull request #13362: Add NHWC layout support to Pooling (cuDNN only)

apeforest commented on a change in pull request #13362: Add NHWC layout support to Pooling (cuDNN only)
URL: https://github.com/apache/incubator-mxnet/pull/13362#discussion_r238951040
 
 

 ##########
 File path: src/operator/nn/cudnn/cudnn_pooling-inl.h
 ##########
 @@ -73,15 +73,17 @@ class CuDNNPoolingOp {
     CUDNN_CALL(cudnnDestroyPoolingDescriptor(pooling_desc_));
   }
 
-  void Forward(const OpContext &ctx, const TBlob &in_data,
+  // Return boolean saying whether pooling configuration is supported.
+  bool Forward(const OpContext &ctx, const TBlob &in_data,
 
 Review comment:
   Is this boolean return necessary? I don't find it in other operators. What happens if it returns false?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services