You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by prashanthvarma <gi...@git.apache.org> on 2016/03/23 23:32:08 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
GitHub user prashanthvarma opened a pull request:
https://github.com/apache/cloudstack/pull/1452
CLOUDSTACK-9322: Support for Internal LB fuctionality with Nuage VSP SDN Plugin including Marvin tests
Task: https://issues.apache.org/jira/browse/CLOUDSTACK-9322
PR contents:
1) UI changes to support LB provider “InternalLbVm” during VPC offering creation.
2) Bug fix for CLOUDSTACK-9320.
3) Nuage VSP SDN Plugin related enhancements for VPC network functionality.
4) Marvin test coverage for Internal LB support on master with Nuage VSP SDN Plugin.
5) Enhancements on our exiting Marvin test code (nuagevsp plugins directory).
6) PyFlakes & PEP8 compliance with our Marvin test code.
Test run:
CloudStack$ nosetests --with-marvin --marvin-config=nuage_ant.cfg test/integration/plugins/nuagevsp/ -a tags=nuagevsp
Test results:
Test user data and password reset functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_UserDataPasswordReset | Status : SUCCESS ===
ok
Test Nuage VSP VPC Offering with different combinations of LB service providers ... === TestName: test_01_nuage_internallb_vpc_Offering | Status : SUCCESS ===
ok
Test Nuage VSP VPC Network Offering with and without Internal LB service ... === TestName: test_02_nuage_internallb_vpc_network_offering | Status : SUCCESS ===
ok
Test Nuage VSP VPC Networks with and without Internal LB service ... === TestName: test_03_nuage_internallb_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with different combinations of Internal LB rules ... === TestName: test_04_nuage_internallb_rules | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality by performing (wget) traffic tests within a VPC ... === TestName: test_05_nuage_internallb_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with different LB algorithms by performing (wget) traffic tests ... === TestName: test_06_nuage_internallb_algorithms_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with restarts of VPC network components by performing (wget) ... === TestName: test_07_nuage_internallb_vpc_network_restarts_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with InternalLbVm appliance operations by performing (wget) ... === TestName: test_08_nuage_internallb_appliance_operations_traffic | Status : SUCCESS ===
ok
Test Basic VPC Network Functionality with Nuage VSP SDN plugin ... === TestName: test_nuage_vpc_network | Status : SUCCESS ===
ok
Test Nuage VSP SDN plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 11 tests in 12094.705s
OK
Test run logs:
PEP8 & PyFlakes Compliance:
CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/*.py
CloudStack$ pyflakes test/integration/plugins/nuagevsp/nuageTestCase.py
CloudStack$ pyflakes test/integration/plugins/nuagevsp/test_nuage_password_reset.py
CloudStack$ pyflakes test/integration/plugins/nuagevsp/test_nuage_vpc_internal_lb.py
CloudStack$ pyflakes test/integration/plugins/nuagevsp/test_nuage_vpc_network.py
CloudStack$ pyflakes test/integration/plugins/nuagevsp/test_nuage_vsp.py
CloudStack$ pyflakes test/integration/plugins/nuagevsp/*.py
#CLOUDSTACK-9322
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prashanthvarma/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1452.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1452
----
commit be67e5cf0649e906291883d974873fb9f49aaff2
Author: Nick Livens <ni...@nuagenetworks.net>
Date: 2016-02-18T10:03:34Z
CLOUDSTACK-9322 : Changes to support InternalLbVm with Nuage VSP plugin
commit 7f811d9962e4112ac789129c3e73c4652db00c54
Author: Nick Livens <ni...@nuagenetworks.net>
Date: 2016-03-21T13:34:18Z
CLOUDSTACK-9320 : InternalLBVM is not getting destroyed when the last Internal Load Balancer rule is removed for the corresponding source IP address
commit 12085aae2caa4562dd7740d857e21f746d5a7748
Author: Prashanth Manthena <pr...@alcatel-lucent.com>
Date: 2016-03-23T14:59:41Z
CLOUDSTACK-9322 : Marvin tests for Internal Lb with Nuage VSP
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211099345
@swill LGTM based on testing and code walkthrough
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by pedro-martins <gi...@git.apache.org>.
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-202163598
Hi @prashanthvarma.
How about to use String.format() to create the strings in the loggers? The use of String format will turn the strings in the logs more legible.
Also, at line 344, could you use Collection.isEmpty(internalLbVms) instead of "internalLbVms == null || internalLbVms.isEmpty()" ?
Ty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by KrisSterckx <gi...@git.apache.org>.
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-210464551
Hi @DaanHoogland is this PR still in the candidate list of 4.9.0 ?
If there is anything that I & the team can facilitate in doing, pls let me know.
Thanks, Kris
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1452
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-214209793
@DaanHoogland, We haven't heard from @pedro-martins in a while. Let's hope, he responds soon (or) someone form the community reviews our code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211099195
@prashanthvarma maybe you can incorporate it in the project dir for the plugin somehow. It seems to me to be the best place for it. maybe accompanied with a readme on how to install/test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-214211132
@swill I think this one has enough LGTM and testing and the only question I see remaining has been answerred. @pedro-martins is not responded anymore so let's merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211060040
thanks @prashanthvarma , mostly usefull for users of your sdn solution. Hopefully some of them will test ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by pedro-martins <gi...@git.apache.org>.
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-203581569
@nlivens great! And sorry for the delay =)
I saw that you used the String.format as I suggested, but and about the using of CollectionUtils.isEmpty() in the class org.apache.cloudstack.network.element.InternalLoadBalancerElement.java at line 344? Did you don't like the suggestion or you just has forgotten to change?
Thanks !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-210646612
It seems to be in pretty good order. I would like some code reviews and since there are changes to logic outside of the tests, I would like a full CI run against it. @DaanHoogland are you setup to run at least the networking stuff against this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211092880
@DaanHoogland you are right, that is the main motive :). Let me know, if you want me to publish it elsewhere as well for easier user access.
Thank you !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-210849171
started the suite now but keep in mind that no sdn specific tests are done in it, @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211032986
did the tests and again two failures, replay succeeded
[1452.results.network.txt](https://github.com/apache/cloudstack/files/222681/1452.results.network.txt)
[1452.results.vpc_routers.txt](https://github.com/apache/cloudstack/files/222683/1452.results.vpc_routers.txt)
[1452.results.routers_network_ops.txt](https://github.com/apache/cloudstack/files/222682/1452.results.routers_network_ops.txt)
```
# ssh 192.168.23.5
The authenticity of host '192.168.23.5 (192.168.23.5)' can't be established.
ECDSA key fingerprint is a6:38:aa:5b:07:f9:53:8c:c0:57:19:c7:8f:e4:f1:a7.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '192.168.23.5' (ECDSA) to the list of known hosts.
root@192.168.23.5's password:
# ping -c 3 8.8.8.8
PING 8.8.8.8 (8.8.8.8): 56 data bytes
64 bytes from 8.8.8.8: seq=0 ttl=46 time=24.347 ms
64 bytes from 8.8.8.8: seq=1 ttl=46 time=23.389 ms
64 bytes from 8.8.8.8: seq=2 ttl=46 time=26.818 ms
--- 8.8.8.8 ping statistics ---
3 packets transmitted, 3 packets received, 0% packet loss
round-trip min/avg/max = 23.389/24.851/26.818 ms
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-210643703
@KrisSterckx I think so but not sure. @swill can you put this in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211044426
@DaanHoogland Sure, here is an example Nuage VSP SDN plugin specific Marvin tests config file contents:
{
"zones": [
{
"name": "MyZone",
"guestcidraddress": "10.1.1.0/24",
"dns2": "8.8.6.6",
"dns1": "10.10.0.10",
"physical_networks": [
{
"broadcastdomainrange": "Zone",
"isolationmethods": [
"VLAN"
],
"name": "Management Network",
"traffictypes": [
{
"kvm": "mgmtbr0",
"typ": "Management"
},
{
"kvm": "mgmtbr0",
"typ": "Public"
},
{
"kvm": "mgmtbr0",
"typ": "Storage"
}
],
"providers": [
{
"broadcastdomainrange": "ZONE",
"name": "VirtualRouter"
}
]
},
{
"broadcastdomainrange": "Zone",
"isolationmethods": [
"VSP"
],
"name": "Nuage Network",
"traffictypes": [
{
"kvm": "alubr0",
"typ": "Guest"
}
],
"providers": [
{
"broadcastdomainrange": "ZONE",
"name": "VirtualRouter"
},
{
"broadcastdomainrange": "ZONE",
"name": "NuageVsp",
"devices": [
{
"username": "csproot",
"retryinterval": "60",
"hostname": "10.30.35.129",
"apiversion": "v3_2",
"retrycount": "4",
"password": "csproot",
"port": 8443
}
]
},
{
"broadcastdomainrange": "ZONE",
"name": "VpcVirtualRouter"
},
{
"broadcastdomainrange": "ZONE",
"name": "InternalLbVm"
}
]
}
],
"securitygroupenabled": "false",
"ipranges": [
{
"startip": "10.29.1.1",
"endip": "10.29.9.255",
"netmask": "255.255.0.0",
"gateway": "10.29.0.1"
}
],
"networktype": "Advanced",
"pods": [
{
"endip": "10.20.15.255",
"name": "P0",
"startip": "10.20.8.0",
"netmask": "255.255.0.0",
"clusters": [
{
"clustername": "P0C0",
"hypervisor": "kvm",
"hosts": [
{
"username": "root",
"url": "http://test-kvm",
"password": "password"
}
],
"clustertype": "CloudManaged",
"primaryStorages": [
{
"url": "nfs://10.20.128.14/primary",
"name": "P0C0-primaryStorage"
}
]
}
],
"gateway": "10.20.0.1"
}
],
"internaldns1": "10.10.0.10",
"internaldns2": "",
"secondaryStorages": [
{
"url": "nfs://10.20.128.14/secondary",
"provider": "NFS"
}
]
}
],
"dbSvr": {
"dbSvr": "csc-1",
"passwd": "cloud",
"db": "cloud",
"port": 3306,
"user": "cloud"
},
"logger":
{
"LogFolderPath": "/tmp/"
},
"globalConfig": [
{
"name": "storage.cleanup.interval",
"value": "300"
},
{
"name": "direct.agent.load.size",
"value": "1000"
},
{
"name": "default.page.size",
"value": "10000"
},
{
"name": "instance.name",
"value": "VM"
},
{
"name": "workers",
"value": "10"
},
{
"name": "vm.op.wait.interval",
"value": "5"
},
{
"name": "account.cleanup.interval",
"value": "600"
},
{
"name": "guest.domain.suffix",
"value": "test.d1c.nuagenetworks.net"
},
{
"name": "expunge.delay",
"value": "60"
},
{
"name": "vm.allocation.algorithm",
"value": "random"
},
{
"name": "expunge.interval",
"value": "60"
},
{
"name": "expunge.workers",
"value": "3"
},
{
"name": "secstorage.allowed.internal.sites",
"value": "10.0.0.0/16"
},
{
"name": "check.pod.cidrs",
"value": "true"
}
],
"mgtSvr": [
{
"mgtSvrIp": "csc-1",
"port": 8096,
"user": "root",
"passwd": "password"
}
]
}
Let me know, if you need anything else from our side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211453267
@pedro-martins can you live with the present state?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-202859071
@pedro-martins Updated the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211038147
@prashanthvarma can you publish nuage_ant.cfg?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211116802
@DaanHoogland That's a good suggestion. We will discuss on the optimal location in the plugin's project directory, and incorporate them in the next PR.
Thank you for the review and suggestions !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211370314
I think this is ready pending 1 more LGTM code review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-203794406
@pedro-martins, I do like it, but we didn't change that code, we just restructured it a bit so I didn't want to touch the original code, I can still make that change though, that's not an issue :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---