You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "crepererum (via GitHub)" <gi...@apache.org> on 2024/10/29 12:36:56 UTC
[PR] fix: enable TLS roots for flight CLI client [arrow-rs]
crepererum opened a new pull request, #6640:
URL: https://github.com/apache/arrow-rs/pull/6640
# Which issue does this PR close?
\-
# Rationale for this change
Otherwise you get:
```text
Error: setup client
Caused by:
0: connect to endpoint
1: transport error
2: invalid peer certificate: UnknownIssuer
3: invalid peer certificate: UnknownIssuer
```
Also see https://github.com/hyperium/tonic/issues/1904 .
# What changes are included in this PR?
Just call the method that registers the roots that we include via feature flags anyways.
# Are there any user-facing changes?
TLS works again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: enable TLS roots for flight CLI client [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #6640:
URL: https://github.com/apache/arrow-rs/pull/6640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: enable TLS roots for flight CLI client [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #6640:
URL: https://github.com/apache/arrow-rs/pull/6640#issuecomment-2444338373
Ideally we'd have a test of this, but I don't feel strongly and it is probably difficult to setup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: enable TLS roots for flight CLI client [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #6640:
URL: https://github.com/apache/arrow-rs/pull/6640#issuecomment-2444528048
That sounds like it could very well end up being flaky, I think let's leave it for now and we can always revisit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: enable TLS roots for flight CLI client [arrow-rs]
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on PR #6640:
URL: https://github.com/apache/arrow-rs/pull/6640#issuecomment-2444523285
> Ideally we'd have a test of this, but I don't feel strongly and it is probably difficult to setup
I thought about that, but that would require that we have a server that has a certificate that is accepted by the Mozilla CA bundle, so without additional infrastructure, I don't think that's feasible.
Or we do something "stupid" like point the client to `https://apache.org` and check the error message that should say something like "not found" (because the gRPC endpoint isn't implemented) but that kinda proofs that the TLS connection worked. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org