You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2016/11/21 19:07:25 UTC

Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53960/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Repository: atlas


Description
-------

ATLAS-1307: Integration test calls routing via the Client.


Diffs
-----

  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
  client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 1d50884 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java e7af0b2 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 50ca842 
  webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java f9e4c40 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 18d4642 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
  webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 9aff145 
  webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java b6dae4d 

Diff: https://reviews.apache.org/r/53960/diff/


Testing
-------

All tests passing


Thanks,

Apoorv Naik

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53960/#review158226
-----------------------------------------------------------




webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java (line 389)
<https://reviews.apache.org/r/53960/#comment229019>

    better to overload the callAPI methods to have anotgher method for GET calls which dont have a requestObject


- Suma Shivaprasad


On Nov. 21, 2016, 7:07 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53960/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 7:07 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1307: Integration test calls routing via the Client.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 1d50884 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java e7af0b2 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 50ca842 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java f9e4c40 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 18d4642 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 9aff145 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java b6dae4d 
> 
> Diff: https://reviews.apache.org/r/53960/diff/
> 
> 
> Testing
> -------
> 
> All tests passing
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

Posted by Apoorv Naik <na...@gmail.com>.

> On Dec. 7, 2016, 3:54 a.m., Suma Shivaprasad wrote:
> > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java, line 102
> > <https://reviews.apache.org/r/53960/diff/1-2/?file=1568170#file1568170line102>
> >
> >     use constantf for qualifiedName and hive_db

Will fix as a part of ATLAS-1311


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53960/#review158293
-----------------------------------------------------------


On Dec. 7, 2016, 12:30 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53960/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 12:30 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1307
>     https://issues.apache.org/jira/browse/ATLAS-1307
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1307: Integration test calls routing via the Client.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java e7af0b2 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/53960/diff/
> 
> 
> Testing
> -------
> 
> All tests passing
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53960/#review158293
-----------------------------------------------------------




webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java (line 98)
<https://reviews.apache.org/r/53960/#comment229066>

    use constantf for qualifiedName and hive_db


- Suma Shivaprasad


On Dec. 7, 2016, 12:30 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53960/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 12:30 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1307
>     https://issues.apache.org/jira/browse/ATLAS-1307
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1307: Integration test calls routing via the Client.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java e7af0b2 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/53960/diff/
> 
> 
> Testing
> -------
> 
> All tests passing
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53960/#review158416
-----------------------------------------------------------


Ship it!




Ship It!

- Suma Shivaprasad


On Dec. 7, 2016, 12:30 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53960/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 12:30 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1307
>     https://issues.apache.org/jira/browse/ATLAS-1307
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1307: Integration test calls routing via the Client.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java e7af0b2 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/53960/diff/
> 
> 
> Testing
> -------
> 
> All tests passing
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

Posted by Apoorv Naik <na...@gmail.com>.

> On Dec. 7, 2016, 3:56 a.m., Suma Shivaprasad wrote:
> > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java, line 68
> > <https://reviews.apache.org/r/53960/diff/2/?file=1578164#file1578164line68>
> >
> >     switch to the modified API wo null for this IT

Can't do here as the signature causes conflicts and some other methods are affected by this change too.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53960/#review158294
-----------------------------------------------------------


On Dec. 7, 2016, 12:30 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53960/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 12:30 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1307
>     https://issues.apache.org/jira/browse/ATLAS-1307
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1307: Integration test calls routing via the Client.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java e7af0b2 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/53960/diff/
> 
> 
> Testing
> -------
> 
> All tests passing
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53960/#review158294
-----------------------------------------------------------




webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java (line 62)
<https://reviews.apache.org/r/53960/#comment229067>

    switch to the modified API wo null for this IT


- Suma Shivaprasad


On Dec. 7, 2016, 12:30 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53960/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 12:30 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1307
>     https://issues.apache.org/jira/browse/ATLAS-1307
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1307: Integration test calls routing via the Client.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java e7af0b2 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/53960/diff/
> 
> 
> Testing
> -------
> 
> All tests passing
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53960/
-----------------------------------------------------------

(Updated Dec. 7, 2016, 12:30 a.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Bugs: ATLAS-1307
    https://issues.apache.org/jira/browse/ATLAS-1307


Repository: atlas


Description
-------

ATLAS-1307: Integration test calls routing via the Client.


Diffs
-----

  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
  client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d 
  client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
  client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java e7af0b2 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
  webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
  webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
  webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 

Diff: https://reviews.apache.org/r/53960/diff/


Testing
-------

All tests passing


Thanks,

Apoorv Naik

Re: Review Request 53960: ATLAS-1307: Integration test calls routing via the Client.

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53960/
-----------------------------------------------------------

(Updated Dec. 6, 2016, 10:39 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Changes
-------

Addressed review comments.


Repository: atlas


Description
-------

ATLAS-1307: Integration test calls routing via the Client.


Diffs (updated)
-----

  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
  client/src/main/java/org/apache/atlas/AtlasClient.java 70e1a0d 
  client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
  client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java e7af0b2 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
  webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
  webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
  webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 

Diff: https://reviews.apache.org/r/53960/diff/


Testing
-------

All tests passing


Thanks,

Apoorv Naik