You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/28 05:22:21 UTC
[GitHub] [flink-kubernetes-operator] SteNicholas opened a new pull request, #247: [FLINK-27668] Document dynamic operator configuration
SteNicholas opened a new pull request, #247:
URL: https://github.com/apache/flink-kubernetes-operator/pull/247
The Kubernetes operator now support dynamic config changes through the operator ConfigMap.This feature is not documented properly and it should be added to the operations/configuration page.
**The brief change log**
- Document dynamic operator configuration in the `operations/configuration` page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #247: [FLINK-27668] Document dynamic operator configuration
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #247:
URL: https://github.com/apache/flink-kubernetes-operator/pull/247#discussion_r886448233
##########
docs/content/docs/operations/configuration.md:
##########
@@ -50,11 +50,39 @@ defaultConfiguration:
To learn more about metrics and logging configuration please refer to the dedicated [docs page]({{< ref "docs/operations/metrics-logging" >}}).
+## Dynamic Operator Configuration
+
+The Kubernetes operator supports dynamic config changes through the operator ConfigMaps. Dynamic operator configuration is enabled by default, and can be disabled by setting `kubernetes.operator.dynamic.config.enabled` to false. Time interval for checking dynamic config changes is specified by `kubernetes.operator.dynamic.config.check.interval` of which default value is 5 minutes.
+
+Verify whether dynamic operator configuration updates is enabled via the `deploy/flink-kubernetes-operator` log has:
+
+```
+2022-05-28 13:08:29,222 o.a.f.k.o.c.FlinkConfigManager [INFO ] Enabled dynamic config updates, checking config changes every PT5M
+```
+
+When the interval for the controller to reschedule the reconcile process need to change with 30 seconds, the ConfigMap can be directly edited via `kubectl patch` or `kubectl edit` command. The `kubernetes.operator.reconciler.reschedule.interval` config option, of which default value is 60 seconds, can directly change to 30s in the `defaultConfiguration` section:
+
+```yaml
+defaultConfiguration:
+ create: true
+ append: false
+ flink-conf.yaml: |+
+ # Flink Config Overrides
+ kubernetes.operator.reconciler.reschedule.interval: 30 s
+```
Review Comment:
Did you try this? I think updating the Helm values won't upgrade the configmap (if the operator is already running)
So please change this to simply:
```
To change config values dynamically the ConfigMap can be directly edited via `kubectl patch` or `kubectl edit` command. For example to change the reschedule interval you can override `kubernetes.operator.reconciler.reschedule.interval`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #247: [FLINK-27668] Document dynamic operator configuration
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #247:
URL: https://github.com/apache/flink-kubernetes-operator/pull/247#discussion_r884250202
##########
docs/content/docs/operations/configuration.md:
##########
@@ -50,11 +50,50 @@ defaultConfiguration:
To learn more about metrics and logging configuration please refer to the dedicated [docs page]({{< ref "docs/operations/metrics-logging" >}}).
+## Dynamic Operator Configuration
+
+The Kubernetes operator supports dynamic config changes through the operator ConfigMaps. Dynamic operator configuration can be enabled by setting `kubernetes.operator.dynamic.config.enabled` to true. Time interval for checking dynamic config changes is specified by `kubernetes.operator.dynamic.config.check.interval` of which default value is 5 minutes.
+
+Verify whether dynamic operator configuration updates is enabled via the `deploy/flink-kubernetes-operator` log has:
+
+```
+2022-05-28 13:08:29,222 o.a.f.k.o.c.FlinkConfigManager [INFO ] Enabled dynamic config updates, checking config changes every PT5M
+```
+
+For example, the default configuration of `flink-conf.yaml` in the `defaultConfiguration` section of the Helm `values.yaml` file is as follows:
+
+```
+defaultConfiguration:
+ create: true
+ append: false
+ flink-conf.yaml: |+
+ # Flink Config Overrides
+ kubernetes.operator.reconciler.reschedule.interval: 60 s
+```
+
+When the interval for the controller to reschedule the reconcile process need to change with 30 seconds, `kubernetes.operator.reconciler.reschedule.interval` in the `defaultConfiguration` section can directly change to 30s:
+
+```
+defaultConfiguration:
+ create: true
+ append: false
+ flink-conf.yaml: |+
+ # Flink Config Overrides
+ kubernetes.operator.reconciler.reschedule.interval: 30 s
+```
Review Comment:
I think this is not a good example because if you try to update the configmap through the Helm chart (using helm-upgrade) nothing will happen because helm only checks if the configmap is present. It will not update it.
We should simply show an example of editing the configmap directly.
##########
docs/content/docs/operations/configuration.md:
##########
@@ -50,11 +50,50 @@ defaultConfiguration:
To learn more about metrics and logging configuration please refer to the dedicated [docs page]({{< ref "docs/operations/metrics-logging" >}}).
+## Dynamic Operator Configuration
+
+The Kubernetes operator supports dynamic config changes through the operator ConfigMaps. Dynamic operator configuration can be enabled by setting `kubernetes.operator.dynamic.config.enabled` to true. Time interval for checking dynamic config changes is specified by `kubernetes.operator.dynamic.config.check.interval` of which default value is 5 minutes.
Review Comment:
We should say that it is enabled by default, and can be **disabled** with the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] SteNicholas commented on pull request #247: [FLINK-27668] Document dynamic operator configuration
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on PR #247:
URL: https://github.com/apache/flink-kubernetes-operator/pull/247#issuecomment-1140177723
@gyfora , PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #247: [FLINK-27668] Document dynamic operator configuration
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #247:
URL: https://github.com/apache/flink-kubernetes-operator/pull/247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org