You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jb...@apache.org on 2005/09/12 04:38:30 UTC
svn commit: r280240 -
/geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
Author: jboynes
Date: Sun Sep 11 19:38:27 2005
New Revision: 280240
URL: http://svn.apache.org/viewcvs?rev=280240&view=rev
Log:
remove mail as there is no reasonable default for the server
Modified:
geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
Modified: geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
URL: http://svn.apache.org/viewcvs/geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml?rev=280240&r1=280239&r2=280240&view=diff
==============================================================================
--- geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml (original)
+++ geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml Sun Sep 11 19:38:27 2005
@@ -136,16 +136,6 @@
<uri>geronimo/jars/geronimo-derby-${geronimo_version}.jar</uri>
</dependency>
- <!-- mail -->
- <dependency>
- <uri>geronimo/jars/geronimo-mail-${geronimo_version}.jar</uri>
- </dependency>
-
- <!-- This little puppy will register a null transport for SMTP -->
-<!-- <dependency>-->
-<!-- <uri>geronimo-spec/jars/geronimo-null-SMTP-SNAPSHOT.jar</uri>-->
-<!-- </dependency>-->
-
<gbean name="DefaultThreadPool" class="org.apache.geronimo.pool.ThreadPool">
<attribute name="keepAliveTime">5000</attribute>
<attribute name="poolSize">30</attribute>
@@ -222,13 +212,6 @@
</gbean>
<gbean gbeanName="geronimo.server:j2eeType=JVM,J2EEServer=geronimo,name=JVM" class="org.apache.geronimo.j2ee.management.impl.JVMImpl"/>
-
-
- <gbean name="mail/MailSession" class="org.apache.geronimo.mail.MailGBean">
- <attribute name="properties">
- mail.smtp.host=mail.apache.com
- </attribute>
- </gbean>
<gbean name="eis/JAXR" class="org.apache.geronimo.webservices.jaxr.JAXRGBean"/>
Re: svn commit: r280240 - /geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
Posted by David Jencks <da...@yahoo.com>.
On Sep 11, 2005, at 9:56 PM, Aaron Mulder wrote:
> On Sun, 11 Sep 2005, Jeremy Boynes wrote:
>> There are no reasonable defaults for the server and it's configuration
>> (localhost only works on /some/ Unix-like distros) so I don't think it
>> should be included in the default server plan.
>>
>> I think we should provide an example that shows people how to
>> configure
>> mail in both of two ways:
>> 1) as part of their application
>> 2) as a separate plan that can be customized as needed along with info
>> on how to reference it from an application plan. This is what we
>> do
>> in the CTS setup.
>
> OK.
>
>> The SMTP provider does work when configured correctly. Part of that
>> setup includes getting the provider jar into a suitable classloader
>> (so
>> that the properties files in META-INF get resolved correctly). It's
>> just
>> messy due to some aspects of the mail API.
>
> Can you give a blow by blow? Do the classloaders work if we
> create a configuration with dependencies on the spec JARs and provider
> JAR? What is the provider JAR called? What GBeans do we need to
> declare?
> Can the user declare a normal resource reference of type
> javax.mail.Session, and if so, how do they resolve it in the Geronimo
> plan
> to point to resource declared in the mail Configuration?
>
> David J, can we add dependencies to a Configuration in the
> config.xml? That is, if a user deployed a mail configuration, can they
> just tell o/a/g/Server to depend on it or would they just list both
> o/a/g/Server and the mail plan as dependencies in their app plan?
That would be an import not a dependency, and no you can't change
either the imports or the dependencies. I think that you should not be
able to change the classpath by using config.xml. So, you would list
o/a/g/Server and the mail configuration as imports or the parentId.
thanks
david jencks
Re: svn commit: r280240 - /geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
Posted by Aaron Mulder <am...@alumni.princeton.edu>.
On Sun, 11 Sep 2005, Jeremy Boynes wrote:
> There are no reasonable defaults for the server and it's configuration
> (localhost only works on /some/ Unix-like distros) so I don't think it
> should be included in the default server plan.
>
> I think we should provide an example that shows people how to configure
> mail in both of two ways:
> 1) as part of their application
> 2) as a separate plan that can be customized as needed along with info
> on how to reference it from an application plan. This is what we do
> in the CTS setup.
OK.
> The SMTP provider does work when configured correctly. Part of that
> setup includes getting the provider jar into a suitable classloader (so
> that the properties files in META-INF get resolved correctly). It's just
> messy due to some aspects of the mail API.
Can you give a blow by blow? Do the classloaders work if we
create a configuration with dependencies on the spec JARs and provider
JAR? What is the provider JAR called? What GBeans do we need to declare?
Can the user declare a normal resource reference of type
javax.mail.Session, and if so, how do they resolve it in the Geronimo plan
to point to resource declared in the mail Configuration?
David J, can we add dependencies to a Configuration in the
config.xml? That is, if a user deployed a mail configuration, can they
just tell o/a/g/Server to depend on it or would they just list both
o/a/g/Server and the mail plan as dependencies in their app plan?
Thanks,
Aaron
Re: svn commit: r280240 - /geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
Posted by Jeremy Boynes <jb...@apache.org>.
Aaron Mulder wrote:
> I'm fine if we include mail as a separate plan. Maybe I
> misinterpreted the commit, but it looked like it was removed entirely. On
> the other hand, if we don't have a working SMTP provider, then parhaps
> that's for the best. I haven't yet figured out the actual status of our
> mail implementation.
>
There are no reasonable defaults for the server and it's configuration
(localhost only works on /some/ Unix-like distros) so I don't think it
should be included in the default server plan.
I think we should provide an example that shows people how to configure
mail in both of two ways:
1) as part of their application
2) as a separate plan that can be customized as needed along with info
on how to reference it from an application plan. This is what we do
in the CTS setup.
The SMTP provider does work when configured correctly. Part of that
setup includes getting the provider jar into a suitable classloader (so
that the properties files in META-INF get resolved correctly). It's just
messy due to some aspects of the mail API.
> Anyway, generally speaking, I don't really fancy properties for
> manageable attributes. Particularly not for those we know will be
> interesting. I think we should have a set of manageable attributes like
> "SMTP Server", "SMTP Username", "SMTP Password", "SMTP SSL Enabled", "SMTP
> Port", etc. -- the stuff you configure when you configure a mail client.
> I don't like giving just a big text area and figuring the user needs to
> know what magic property names to put in there.
>
SMTPTransportGBean does this. However, it does it by setting the
applicable values into a Properties passed to the mail provider. This
works but I can't help but wonder if there is a better way.
--
Jeremy
Re: svn commit: r280240 - /geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
Posted by David Jencks <da...@yahoo.com>.
On Sep 11, 2005, at 9:15 PM, Aaron Mulder wrote:
> I'm fine if we include mail as a separate plan. Maybe I
> misinterpreted the commit, but it looked like it was removed entirely.
> On
> the other hand, if we don't have a working SMTP provider, then parhaps
> that's for the best. I haven't yet figured out the actual status of
> our
> mail implementation.
I haven't either, and the commit did remove the mail gbean entirely.
>
> Anyway, generally speaking, I don't really fancy properties for
> manageable attributes. Particularly not for those we know will be
> interesting. I think we should have a set of manageable attributes
> like
> "SMTP Server", "SMTP Username", "SMTP Password", "SMTP SSL Enabled",
> "SMTP
> Port", etc. -- the stuff you configure when you configure a mail
> client.
> I don't like giving just a big text area and figuring the user needs to
> know what magic property names to put in there.
I'm much more ok with this if the attributes are completely standard: I
don't know if they are.
thanks
david jencks
>
> Aaron
>
> On Sun, 11 Sep 2005, David Jencks wrote:
>> I think we should include this as an additional configuration rather
>> than as part of j2ee-server-plan.xml. It is quite possible that users
>> will want to use Sun's javamail that they get for themselves, and we
>> should not require modifying our default plans to make that possible.
>>
>> Also, I'd like to point out again GERONIMO-1003 which makes gbean
>> attributes manageable by default. If anyone objects to this please
>> speak up sooner rather than later. I may have misunderstood your
>> comment, but right now the properties attribute is manageable. I'm
>> not
>> sure how much separating out the server name would buy us.
>>
>> thanks
>> david jencks
>>
>> On Sep 11, 2005, at 8:55 PM, Aaron Mulder wrote:
>>
>>> I don't get it. Do we have a working SMTP transport? If so,
>>> let's leave the GBean in, provide a manageable property for the
>>> server
>>> name, and let the user configure it. It can default to localhost,
>>> which
>>> will work on many Linux machines. I could certainly add a property
>>> for it
>>> to the installer.
>>>
>>> Aaron
>>>
>>> On Mon, 12 Sep 2005 jboynes@apache.org wrote:
>>>> Author: jboynes
>>>> Date: Sun Sep 11 19:38:27 2005
>>>> New Revision: 280240
>>>>
>>>> URL: http://svn.apache.org/viewcvs?rev=280240&view=rev
>>>> Log:
>>>> remove mail as there is no reasonable default for the server
>>>>
>>>> Modified:
>>>> geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
>>>>
>>>> Modified:
>>>> geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
>>>> URL:
>>>> http://svn.apache.org/viewcvs/geronimo/trunk/modules/assembly/src/
>>>> plan/j2ee-server-plan.xml?rev=280240&r1=280239&r2=280240&view=diff
>>>> ====================================================================
>>>> ==
>>>> ========
>>>> --- geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
>>>> (original)
>>>> +++ geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
>>>> Sun
>>>> Sep 11 19:38:27 2005
>>>> @@ -136,16 +136,6 @@
>>>>
>>>> <uri>geronimo/jars/geronimo-derby-${geronimo_version}.jar</uri>
>>>> </dependency>
>>>>
>>>> - <!-- mail -->
>>>> - <dependency>
>>>> -
>>>> <uri>geronimo/jars/geronimo-mail-${geronimo_version}.jar</uri>
>>>> - </dependency>
>>>> -
>>>> - <!-- This little puppy will register a null transport for SMTP
>>>> -->
>>>> -<!-- <dependency>-->
>>>> -<!--
>>>> <uri>geronimo-spec/jars/geronimo-null-SMTP-SNAPSHOT.jar</uri>-->
>>>> -<!-- </dependency>-->
>>>> -
>>>> <gbean name="DefaultThreadPool"
>>>> class="org.apache.geronimo.pool.ThreadPool">
>>>> <attribute name="keepAliveTime">5000</attribute>
>>>> <attribute name="poolSize">30</attribute>
>>>> @@ -222,13 +212,6 @@
>>>> </gbean>
>>>>
>>>> <gbean
>>>> gbeanName="geronimo.server:
>>>> j2eeType=JVM,J2EEServer=geronimo,name=JVM"
>>>> class="org.apache.geronimo.j2ee.management.impl.JVMImpl"/>
>>>> -
>>>> -
>>>> - <gbean name="mail/MailSession"
>>>> class="org.apache.geronimo.mail.MailGBean">
>>>> - <attribute name="properties">
>>>> - mail.smtp.host=mail.apache.com
>>>> - </attribute>
>>>> - </gbean>
>>>>
>>>> <gbean name="eis/JAXR"
>>>> class="org.apache.geronimo.webservices.jaxr.JAXRGBean"/>
>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
>
Re: svn commit: r280240 - /geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
Posted by Aaron Mulder <am...@alumni.princeton.edu>.
I'm fine if we include mail as a separate plan. Maybe I
misinterpreted the commit, but it looked like it was removed entirely. On
the other hand, if we don't have a working SMTP provider, then parhaps
that's for the best. I haven't yet figured out the actual status of our
mail implementation.
Anyway, generally speaking, I don't really fancy properties for
manageable attributes. Particularly not for those we know will be
interesting. I think we should have a set of manageable attributes like
"SMTP Server", "SMTP Username", "SMTP Password", "SMTP SSL Enabled", "SMTP
Port", etc. -- the stuff you configure when you configure a mail client.
I don't like giving just a big text area and figuring the user needs to
know what magic property names to put in there.
Aaron
On Sun, 11 Sep 2005, David Jencks wrote:
> I think we should include this as an additional configuration rather
> than as part of j2ee-server-plan.xml. It is quite possible that users
> will want to use Sun's javamail that they get for themselves, and we
> should not require modifying our default plans to make that possible.
>
> Also, I'd like to point out again GERONIMO-1003 which makes gbean
> attributes manageable by default. If anyone objects to this please
> speak up sooner rather than later. I may have misunderstood your
> comment, but right now the properties attribute is manageable. I'm not
> sure how much separating out the server name would buy us.
>
> thanks
> david jencks
>
> On Sep 11, 2005, at 8:55 PM, Aaron Mulder wrote:
>
> > I don't get it. Do we have a working SMTP transport? If so,
> > let's leave the GBean in, provide a manageable property for the server
> > name, and let the user configure it. It can default to localhost,
> > which
> > will work on many Linux machines. I could certainly add a property
> > for it
> > to the installer.
> >
> > Aaron
> >
> > On Mon, 12 Sep 2005 jboynes@apache.org wrote:
> >> Author: jboynes
> >> Date: Sun Sep 11 19:38:27 2005
> >> New Revision: 280240
> >>
> >> URL: http://svn.apache.org/viewcvs?rev=280240&view=rev
> >> Log:
> >> remove mail as there is no reasonable default for the server
> >>
> >> Modified:
> >> geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
> >>
> >> Modified:
> >> geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
> >> URL:
> >> http://svn.apache.org/viewcvs/geronimo/trunk/modules/assembly/src/
> >> plan/j2ee-server-plan.xml?rev=280240&r1=280239&r2=280240&view=diff
> >> ======================================================================
> >> ========
> >> --- geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
> >> (original)
> >> +++ geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml Sun
> >> Sep 11 19:38:27 2005
> >> @@ -136,16 +136,6 @@
> >>
> >> <uri>geronimo/jars/geronimo-derby-${geronimo_version}.jar</uri>
> >> </dependency>
> >>
> >> - <!-- mail -->
> >> - <dependency>
> >> -
> >> <uri>geronimo/jars/geronimo-mail-${geronimo_version}.jar</uri>
> >> - </dependency>
> >> -
> >> - <!-- This little puppy will register a null transport for SMTP
> >> -->
> >> -<!-- <dependency>-->
> >> -<!--
> >> <uri>geronimo-spec/jars/geronimo-null-SMTP-SNAPSHOT.jar</uri>-->
> >> -<!-- </dependency>-->
> >> -
> >> <gbean name="DefaultThreadPool"
> >> class="org.apache.geronimo.pool.ThreadPool">
> >> <attribute name="keepAliveTime">5000</attribute>
> >> <attribute name="poolSize">30</attribute>
> >> @@ -222,13 +212,6 @@
> >> </gbean>
> >>
> >> <gbean
> >> gbeanName="geronimo.server:j2eeType=JVM,J2EEServer=geronimo,name=JVM"
> >> class="org.apache.geronimo.j2ee.management.impl.JVMImpl"/>
> >> -
> >> -
> >> - <gbean name="mail/MailSession"
> >> class="org.apache.geronimo.mail.MailGBean">
> >> - <attribute name="properties">
> >> - mail.smtp.host=mail.apache.com
> >> - </attribute>
> >> - </gbean>
> >>
> >> <gbean name="eis/JAXR"
> >> class="org.apache.geronimo.webservices.jaxr.JAXRGBean"/>
> >>
> >>
> >>
> >>
> >
>
>
Re: svn commit: r280240 - /geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
Posted by David Jencks <da...@yahoo.com>.
I think we should include this as an additional configuration rather
than as part of j2ee-server-plan.xml. It is quite possible that users
will want to use Sun's javamail that they get for themselves, and we
should not require modifying our default plans to make that possible.
Also, I'd like to point out again GERONIMO-1003 which makes gbean
attributes manageable by default. If anyone objects to this please
speak up sooner rather than later. I may have misunderstood your
comment, but right now the properties attribute is manageable. I'm not
sure how much separating out the server name would buy us.
thanks
david jencks
On Sep 11, 2005, at 8:55 PM, Aaron Mulder wrote:
> I don't get it. Do we have a working SMTP transport? If so,
> let's leave the GBean in, provide a manageable property for the server
> name, and let the user configure it. It can default to localhost,
> which
> will work on many Linux machines. I could certainly add a property
> for it
> to the installer.
>
> Aaron
>
> On Mon, 12 Sep 2005 jboynes@apache.org wrote:
>> Author: jboynes
>> Date: Sun Sep 11 19:38:27 2005
>> New Revision: 280240
>>
>> URL: http://svn.apache.org/viewcvs?rev=280240&view=rev
>> Log:
>> remove mail as there is no reasonable default for the server
>>
>> Modified:
>> geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
>>
>> Modified:
>> geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
>> URL:
>> http://svn.apache.org/viewcvs/geronimo/trunk/modules/assembly/src/
>> plan/j2ee-server-plan.xml?rev=280240&r1=280239&r2=280240&view=diff
>> ======================================================================
>> ========
>> --- geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
>> (original)
>> +++ geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml Sun
>> Sep 11 19:38:27 2005
>> @@ -136,16 +136,6 @@
>>
>> <uri>geronimo/jars/geronimo-derby-${geronimo_version}.jar</uri>
>> </dependency>
>>
>> - <!-- mail -->
>> - <dependency>
>> -
>> <uri>geronimo/jars/geronimo-mail-${geronimo_version}.jar</uri>
>> - </dependency>
>> -
>> - <!-- This little puppy will register a null transport for SMTP
>> -->
>> -<!-- <dependency>-->
>> -<!--
>> <uri>geronimo-spec/jars/geronimo-null-SMTP-SNAPSHOT.jar</uri>-->
>> -<!-- </dependency>-->
>> -
>> <gbean name="DefaultThreadPool"
>> class="org.apache.geronimo.pool.ThreadPool">
>> <attribute name="keepAliveTime">5000</attribute>
>> <attribute name="poolSize">30</attribute>
>> @@ -222,13 +212,6 @@
>> </gbean>
>>
>> <gbean
>> gbeanName="geronimo.server:j2eeType=JVM,J2EEServer=geronimo,name=JVM"
>> class="org.apache.geronimo.j2ee.management.impl.JVMImpl"/>
>> -
>> -
>> - <gbean name="mail/MailSession"
>> class="org.apache.geronimo.mail.MailGBean">
>> - <attribute name="properties">
>> - mail.smtp.host=mail.apache.com
>> - </attribute>
>> - </gbean>
>>
>> <gbean name="eis/JAXR"
>> class="org.apache.geronimo.webservices.jaxr.JAXRGBean"/>
>>
>>
>>
>>
>
Re: svn commit: r280240 - /geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
Posted by Aaron Mulder <am...@alumni.princeton.edu>.
I don't get it. Do we have a working SMTP transport? If so,
let's leave the GBean in, provide a manageable property for the server
name, and let the user configure it. It can default to localhost, which
will work on many Linux machines. I could certainly add a property for it
to the installer.
Aaron
On Mon, 12 Sep 2005 jboynes@apache.org wrote:
> Author: jboynes
> Date: Sun Sep 11 19:38:27 2005
> New Revision: 280240
>
> URL: http://svn.apache.org/viewcvs?rev=280240&view=rev
> Log:
> remove mail as there is no reasonable default for the server
>
> Modified:
> geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
>
> Modified: geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
> URL: http://svn.apache.org/viewcvs/geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml?rev=280240&r1=280239&r2=280240&view=diff
> ==============================================================================
> --- geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml (original)
> +++ geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml Sun Sep 11 19:38:27 2005
> @@ -136,16 +136,6 @@
> <uri>geronimo/jars/geronimo-derby-${geronimo_version}.jar</uri>
> </dependency>
>
> - <!-- mail -->
> - <dependency>
> - <uri>geronimo/jars/geronimo-mail-${geronimo_version}.jar</uri>
> - </dependency>
> -
> - <!-- This little puppy will register a null transport for SMTP -->
> -<!-- <dependency>-->
> -<!-- <uri>geronimo-spec/jars/geronimo-null-SMTP-SNAPSHOT.jar</uri>-->
> -<!-- </dependency>-->
> -
> <gbean name="DefaultThreadPool" class="org.apache.geronimo.pool.ThreadPool">
> <attribute name="keepAliveTime">5000</attribute>
> <attribute name="poolSize">30</attribute>
> @@ -222,13 +212,6 @@
> </gbean>
>
> <gbean gbeanName="geronimo.server:j2eeType=JVM,J2EEServer=geronimo,name=JVM" class="org.apache.geronimo.j2ee.management.impl.JVMImpl"/>
> -
> -
> - <gbean name="mail/MailSession" class="org.apache.geronimo.mail.MailGBean">
> - <attribute name="properties">
> - mail.smtp.host=mail.apache.com
> - </attribute>
> - </gbean>
>
> <gbean name="eis/JAXR" class="org.apache.geronimo.webservices.jaxr.JAXRGBean"/>
>
>
>
>