[GitHub] spark pull request #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehous...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16290#discussion_r101883075
  
    --- Diff: R/pkg/R/sparkR.R ---
    @@ -376,6 +377,12 @@ sparkR.session <- function(
         overrideEnvs(sparkConfigMap, paramMap)
       }
     
    +  # NOTE(shivaram): Set default warehouse dir to tmpdir to meet CRAN requirements
    +  # See SPARK-18817 for more details
    +  if (!exists("spark.sql.default.warehouse.dir", envir = sparkConfigMap)) {
    --- End diff --
    
    After rethinking it, we might not need to add an extra sql conf. We just need to know whether the value of `spark.sql.warehouse.dir` is from the users or the original default. If it is the default, R can simply change it. 
    
    Maybe it is a good to-have feature for users to know whether the SQLConf value is from users or from the default. cc @cloud-fan 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org