You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by Suneel Marthi <sm...@apache.org> on 2016/10/22 20:57:33 UTC
Submitting and Handling Github PRs
Wanted to bring up 2 things about managing PRs:
1. Squash all commits before merging PRs to master
2. Include the jira in the final commit before merging to master
Most projects (TLP and Incubator) do it - Mahout, Flink, Pirk, PredictionIO.
For reference, see
https://mahout.apache.org/developers/github.html for how its being done on
Mahout.
Re: Submitting and Handling Github PRs
Posted by Joey Frazee <jo...@icloud.com>.
I've seen some use of Github PR comment templates/pre-filled forms to remind the submitter to do all the necessary stuff:
- JIRA issue opened
- JIRA issue in the title
- Run contrib-check
- Link to Apache CLA form
- Anything else?
It's a nice place to put the info since it's not uncommon for people to start contributing without ever checking whatever guidelines are in place.
I think this is another infra task though?
> On Oct 22, 2016, at 4:13 PM, Timothy Spann <ts...@hortonworks.com> wrote:
>
> That is very helpful
>
>
> On 10/22/16, 5:03 PM, "sblackmon" <sb...@apache.org> wrote:
>
> That’s a nice PR tutorial page. We should add one like it to the streams website.
>
> +1 to squashing and referencing JIRA on every commit message as common practice - should make it easier to follow what’s happened on master branch.
>
> Steve
> On October 22, 2016 at 3:57:54 PM, Suneel Marthi (smarthi@apache.org) wrote:
>
> Wanted to bring up 2 things about managing PRs:
>
> 1. Squash all commits before merging PRs to master
>
> 2. Include the jira in the final commit before merging to master
>
> Most projects (TLP and Incubator) do it - Mahout, Flink, Pirk, PredictionIO.
>
> For reference, see
>
> https://mahout.apache.org/developers/github.html for how its being done on
> Mahout.
>
>
Re: Submitting and Handling Github PRs
Posted by Timothy Spann <ts...@hortonworks.com>.
That is very helpful
On 10/22/16, 5:03 PM, "sblackmon" <sb...@apache.org> wrote:
That’s a nice PR tutorial page. We should add one like it to the streams website.
+1 to squashing and referencing JIRA on every commit message as common practice - should make it easier to follow what’s happened on master branch.
Steve
On October 22, 2016 at 3:57:54 PM, Suneel Marthi (smarthi@apache.org) wrote:
Wanted to bring up 2 things about managing PRs:
1. Squash all commits before merging PRs to master
2. Include the jira in the final commit before merging to master
Most projects (TLP and Incubator) do it - Mahout, Flink, Pirk, PredictionIO.
For reference, see
https://mahout.apache.org/developers/github.html for how its being done on
Mahout.
Re: Submitting and Handling Github PRs
Posted by sblackmon <sb...@apache.org>.
That’s a nice PR tutorial page. We should add one like it to the streams website.
+1 to squashing and referencing JIRA on every commit message as common practice - should make it easier to follow what’s happened on master branch.
Steve
On October 22, 2016 at 3:57:54 PM, Suneel Marthi (smarthi@apache.org) wrote:
Wanted to bring up 2 things about managing PRs:
1. Squash all commits before merging PRs to master
2. Include the jira in the final commit before merging to master
Most projects (TLP and Incubator) do it - Mahout, Flink, Pirk, PredictionIO.
For reference, see
https://mahout.apache.org/developers/github.html for how its being done on
Mahout.
Re: Submitting and Handling Github PRs
Posted by Sven Reimers <sv...@gmail.com>.
Awesome.
Thanks for sharing
Sven
Am 23.10.2016 18:53 schrieb "Wade Chandler" <co...@wadechandler.com>:
> Great, thanks Ate.
>
> Wade
>
>
> ===================
>
> Wade Chandler
> e: consult@wadechandler.com
>
>
>
> > On Oct 23, 2016, at 10:48, Ate Douma <at...@douma.nu> wrote:
> >
> > I'm forwarding a reference about handling PRs from Suneel Marthi (mentor)
> > for the Streams podling, which IMO might also be useful for the NetBeans
> > community to consider.
> >
> > Regards, Ate
> >
> > -------- Forwarded Message --------
> > Subject: Submitting and Handling Github PRs
> > Date: Sat, 22 Oct 2016 16:57:33 -0400
> > From: Suneel Marthi <sm...@apache.org>
> > Reply-To: dev@streams.incubator.apache.org
> > To: dev@streams.incubator.apache.org
> >
> > Wanted to bring up 2 things about managing PRs:
> >
> > 1. Squash all commits before merging PRs to master
> >
> > 2. Include the jira in the final commit before merging to master
> >
> > Most projects (TLP and Incubator) do it - Mahout, Flink, Pirk,
> PredictionIO.
> >
> > For reference, see
> >
> > https://mahout.apache.org/developers/github.html for how its being done
> on
> > Mahout.
> >
>
>
Re: Submitting and Handling Github PRs
Posted by Wade Chandler <co...@wadechandler.com>.
Great, thanks Ate.
Wade
===================
Wade Chandler
e: consult@wadechandler.com
> On Oct 23, 2016, at 10:48, Ate Douma <at...@douma.nu> wrote:
>
> I'm forwarding a reference about handling PRs from Suneel Marthi (mentor)
> for the Streams podling, which IMO might also be useful for the NetBeans
> community to consider.
>
> Regards, Ate
>
> -------- Forwarded Message --------
> Subject: Submitting and Handling Github PRs
> Date: Sat, 22 Oct 2016 16:57:33 -0400
> From: Suneel Marthi <sm...@apache.org>
> Reply-To: dev@streams.incubator.apache.org
> To: dev@streams.incubator.apache.org
>
> Wanted to bring up 2 things about managing PRs:
>
> 1. Squash all commits before merging PRs to master
>
> 2. Include the jira in the final commit before merging to master
>
> Most projects (TLP and Incubator) do it - Mahout, Flink, Pirk, PredictionIO.
>
> For reference, see
>
> https://mahout.apache.org/developers/github.html for how its being done on
> Mahout.
>
Fwd: Submitting and Handling Github PRs
Posted by Ate Douma <at...@douma.nu>.
I'm forwarding a reference about handling PRs from Suneel Marthi (mentor)
for the Streams podling, which IMO might also be useful for the NetBeans
community to consider.
Regards, Ate
-------- Forwarded Message --------
Subject: Submitting and Handling Github PRs
Date: Sat, 22 Oct 2016 16:57:33 -0400
From: Suneel Marthi <sm...@apache.org>
Reply-To: dev@streams.incubator.apache.org
To: dev@streams.incubator.apache.org
Wanted to bring up 2 things about managing PRs:
1. Squash all commits before merging PRs to master
2. Include the jira in the final commit before merging to master
Most projects (TLP and Incubator) do it - Mahout, Flink, Pirk, PredictionIO.
For reference, see
https://mahout.apache.org/developers/github.html for how its being done on
Mahout.
Fwd: Submitting and Handling Github PRs
Posted by Ate Douma <at...@douma.nu>.
I'm forwarding a reference about handling PRs from Suneel Marthi (mentor)
for the Streams podling, which IMO might also be useful for the NetBeans
community to consider.
Regards, Ate
-------- Forwarded Message --------
Subject: Submitting and Handling Github PRs
Date: Sat, 22 Oct 2016 16:57:33 -0400
From: Suneel Marthi <sm...@apache.org>
Reply-To: dev@streams.incubator.apache.org
To: dev@streams.incubator.apache.org
Wanted to bring up 2 things about managing PRs:
1. Squash all commits before merging PRs to master
2. Include the jira in the final commit before merging to master
Most projects (TLP and Incubator) do it - Mahout, Flink, Pirk, PredictionIO.
For reference, see
https://mahout.apache.org/developers/github.html for how its being done on
Mahout.