You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/02 09:18:46 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29180: [SPARK-17333][PYSPARK] Enable mypy on the repository

HyukjinKwon commented on a change in pull request #29180:
URL: https://github.com/apache/spark/pull/29180#discussion_r481926390



##########
File path: dev/lint-python
##########
@@ -122,6 +123,32 @@ function pycodestyle_test {
     fi
 }
 
+function mypy_test {
+    local MYPY_REPORT=
+    local MYPY_STATUS=
+
+    if ! hash "$MYPY_BUILD" 2> /dev/null; then
+        echo "The mypy command was not found."
+        echo "mypy checks failed."
+        # exit 1
+        pip3 install mypy

Review comment:
       Oh let's don't do this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org