You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Adrian Crum <ad...@hlmksw.com> on 2009/09/03 18:57:39 UTC
Re: svn commit: r811020 - /ofbiz/trunk/framework/common/widget/CommonScreens.xml
Jacques,
I suggested removing the default-value, not the entire set element. Did
you test this change with the various themes?
-Adrian
jleroux@apache.org wrote:
> Author: jleroux
> Date: Thu Sep 3 16:43:08 2009
> New Revision: 811020
>
> URL: http://svn.apache.org/viewvc?rev=811020&view=rev
> Log:
> Fix https://issues.apache.org/jira/browse/OFBIZ-2885 as suggested by Adrian - OFBIZ-2885
>
> Modified:
> ofbiz/trunk/framework/common/widget/CommonScreens.xml
>
> Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=811020&r1=811019&r2=811020&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
> +++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Thu Sep 3 16:43:08 2009
> @@ -129,11 +129,6 @@
> <field-map field-name="themeResources" from-field="layoutSettings"/>
> </service>
> <set field="layoutSettings" from-field="themeResources" default-value="${layoutSettings}" global="true"/>
> - <set field="headerTemplateLocation" from-field="layoutSettings.VT_HDR_TMPLT_LOC[0]" default-value="component://common/webcommon/includes/header.ftl"/>
> - <set field="footerTemplateLocation" from-field="layoutSettings.VT_FTR_TMPLT_LOC[0]" default-value="component://common/webcommon/includes/footer.ftl"/>
> - <set field="appbarTemplateLocation" from-field="layoutSettings.VT_NAV_TMPLT_LOC[0]" default-value="component://common/webcommon/includes/appbar.ftl"/>
> - <set field="messagesTemplateLocation" from-field="layoutSettings.VT_MSG_TMPLT_LOC[0]" default-value="component://common/webcommon/includes/messages.ftl"/>
> -
> <property-map resource="CommonHelpUrls" map-name="helpUrlsMap" global="true"/>
> </actions>
> <widgets>
> @@ -209,7 +204,7 @@
> <field-map field-name="userPrefGroupTypeId" value="GLOBAL_PREFERENCES"/>
> </service>
> <set field="userPreferences" from-field="prefResult.userPrefMap" global="true"/>
> -
> +
> <property-map resource="general" map-name="generalProperties" global="true"/>
> <set field="defaultVisualThemeId" from-field="generalProperties.defaultVisualThemeId" default-value="SMOOTH_FEATHER"/>
> <set field="visualThemeId" from-field="userPreferences.VISUAL_THEME" default-value="${defaultVisualThemeId}" global="true"/>
>
>
>
Re: svn commit: r811020 - /ofbiz/trunk/framework/common/widget/CommonScreens.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Jacopo,
I was just willing to do it. Sorry guys, I did it too quickly and had some trouble in the same time and then was not able to get it
back. I thought my external disk (where I have Postgres and backup) was dead when it was just the power supply, pfff...
Jacques
From: "Jacopo Cappellato" <ja...@hotwaxmedia.com>
> Fixed in rev. 811077
>
> Jacopo
>
> On Sep 3, 2009, at 6:57 PM, Adrian Crum wrote:
>
>> Jacques,
>>
>> I suggested removing the default-value, not the entire set element. Did you test this change with the various themes?
>>
>> -Adrian
>>
>> jleroux@apache.org wrote:
>>> Author: jleroux
>>> Date: Thu Sep 3 16:43:08 2009
>>> New Revision: 811020
>>> URL: http://svn.apache.org/viewvc?rev=811020&view=rev
>>> Log:
>>> Fix https://issues.apache.org/jira/browse/OFBIZ-2885 as suggested by Adrian - OFBIZ-2885
>>> Modified:
>>> ofbiz/trunk/framework/common/widget/CommonScreens.xml
>>> Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=811020&r1=811019&r2=811020&view=diff
>>> = = = = = = = = = =====================================================================
>>> --- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
>>> +++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Thu Sep 3 16:43:08 2009
>>> @@ -129,11 +129,6 @@
>>> <field-map field-name="themeResources" from- field="layoutSettings"/>
>>> </service>
>>> <set field="layoutSettings" from- field="themeResources" default-value="${layoutSettings}" global="true"/>
>>> - <set field="headerTemplateLocation" from- field="layoutSettings.VT_HDR_TMPLT_LOC[0]" default-
>>> value="component://common/webcommon/includes/header.ftl"/>
>>> - <set field="footerTemplateLocation" from- field="layoutSettings.VT_FTR_TMPLT_LOC[0]" default-
>>> value="component://common/webcommon/includes/footer.ftl"/>
>>> - <set field="appbarTemplateLocation" from- field="layoutSettings.VT_NAV_TMPLT_LOC[0]" default-
>>> value="component://common/webcommon/includes/appbar.ftl"/>
>>> - <set field="messagesTemplateLocation" from- field="layoutSettings.VT_MSG_TMPLT_LOC[0]" default-
>>> value="component://common/webcommon/includes/messages.ftl"/>
>>> -
>>> <property-map resource="CommonHelpUrls" map- name="helpUrlsMap" global="true"/>
>>> </actions>
>>> <widgets>
>>> @@ -209,7 +204,7 @@
>>> <field-map field-name="userPrefGroupTypeId" value="GLOBAL_PREFERENCES"/>
>>> </service>
>>> <set field="userPreferences" from- field="prefResult.userPrefMap" global="true"/>
>>> - +
>>> <property-map resource="general" map- name="generalProperties" global="true"/>
>>> <set field="defaultVisualThemeId" from- field="generalProperties.defaultVisualThemeId" default-
>>> value="SMOOTH_FEATHER"/>
>>> <set field="visualThemeId" from- field="userPreferences.VISUAL_THEME" default-value="$ {defaultVisualThemeId}"
>>> global="true"/>
>
Re: svn commit: r811020 - /ofbiz/trunk/framework/common/widget/CommonScreens.xml
Posted by Ashish Vijaywargiya <vi...@gmail.com>.
Thanks Jacopo!
--
Ashish
On Fri, Sep 4, 2009 at 12:09 AM, Jacopo Cappellato <
jacopo.cappellato@hotwaxmedia.com> wrote:
> Fixed in rev. 811077
>
> Jacopo
>
>
> On Sep 3, 2009, at 6:57 PM, Adrian Crum wrote:
>
> Jacques,
>>
>> I suggested removing the default-value, not the entire set element. Did
>> you test this change with the various themes?
>>
>> -Adrian
>>
>> jleroux@apache.org wrote:
>>
>>> Author: jleroux
>>> Date: Thu Sep 3 16:43:08 2009
>>> New Revision: 811020
>>> URL: http://svn.apache.org/viewvc?rev=811020&view=rev
>>> Log:
>>> Fix https://issues.apache.org/jira/browse/OFBIZ-2885 as suggested by
>>> Adrian - OFBIZ-2885
>>> Modified:
>>> ofbiz/trunk/framework/common/widget/CommonScreens.xml
>>> Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=811020&r1=811019&r2=811020&view=diff
>>>
>>> ==============================================================================
>>> --- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
>>> +++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Thu Sep 3
>>> 16:43:08 2009
>>> @@ -129,11 +129,6 @@
>>> <field-map field-name="themeResources"
>>> from-field="layoutSettings"/>
>>> </service>
>>> <set field="layoutSettings" from-field="themeResources"
>>> default-value="${layoutSettings}" global="true"/>
>>> - <set field="headerTemplateLocation"
>>> from-field="layoutSettings.VT_HDR_TMPLT_LOC[0]"
>>> default-value="component://common/webcommon/includes/header.ftl"/>
>>> - <set field="footerTemplateLocation"
>>> from-field="layoutSettings.VT_FTR_TMPLT_LOC[0]"
>>> default-value="component://common/webcommon/includes/footer.ftl"/>
>>> - <set field="appbarTemplateLocation"
>>> from-field="layoutSettings.VT_NAV_TMPLT_LOC[0]"
>>> default-value="component://common/webcommon/includes/appbar.ftl"/>
>>> - <set field="messagesTemplateLocation"
>>> from-field="layoutSettings.VT_MSG_TMPLT_LOC[0]"
>>> default-value="component://common/webcommon/includes/messages.ftl"/>
>>> -
>>> <property-map resource="CommonHelpUrls"
>>> map-name="helpUrlsMap" global="true"/>
>>> </actions>
>>> <widgets>
>>> @@ -209,7 +204,7 @@
>>> <field-map field-name="userPrefGroupTypeId"
>>> value="GLOBAL_PREFERENCES"/>
>>> </service>
>>> <set field="userPreferences"
>>> from-field="prefResult.userPrefMap" global="true"/>
>>> - +
>>> <property-map resource="general"
>>> map-name="generalProperties" global="true"/>
>>> <set field="defaultVisualThemeId"
>>> from-field="generalProperties.defaultVisualThemeId"
>>> default-value="SMOOTH_FEATHER"/>
>>> <set field="visualThemeId"
>>> from-field="userPreferences.VISUAL_THEME"
>>> default-value="${defaultVisualThemeId}" global="true"/>
>>>
>>
>
Re: svn commit: r811020 - /ofbiz/trunk/framework/common/widget/CommonScreens.xml
Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
Fixed in rev. 811077
Jacopo
On Sep 3, 2009, at 6:57 PM, Adrian Crum wrote:
> Jacques,
>
> I suggested removing the default-value, not the entire set element.
> Did you test this change with the various themes?
>
> -Adrian
>
> jleroux@apache.org wrote:
>> Author: jleroux
>> Date: Thu Sep 3 16:43:08 2009
>> New Revision: 811020
>> URL: http://svn.apache.org/viewvc?rev=811020&view=rev
>> Log:
>> Fix https://issues.apache.org/jira/browse/OFBIZ-2885 as suggested
>> by Adrian - OFBIZ-2885
>> Modified:
>> ofbiz/trunk/framework/common/widget/CommonScreens.xml
>> Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=811020&r1=811019&r2=811020&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
>> +++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Thu Sep
>> 3 16:43:08 2009
>> @@ -129,11 +129,6 @@
>> <field-map field-name="themeResources" from-
>> field="layoutSettings"/>
>> </service>
>> <set field="layoutSettings" from-
>> field="themeResources" default-value="${layoutSettings}"
>> global="true"/>
>> - <set field="headerTemplateLocation" from-
>> field="layoutSettings.VT_HDR_TMPLT_LOC[0]" default-
>> value="component://common/webcommon/includes/header.ftl"/>
>> - <set field="footerTemplateLocation" from-
>> field="layoutSettings.VT_FTR_TMPLT_LOC[0]" default-
>> value="component://common/webcommon/includes/footer.ftl"/>
>> - <set field="appbarTemplateLocation" from-
>> field="layoutSettings.VT_NAV_TMPLT_LOC[0]" default-
>> value="component://common/webcommon/includes/appbar.ftl"/>
>> - <set field="messagesTemplateLocation" from-
>> field="layoutSettings.VT_MSG_TMPLT_LOC[0]" default-
>> value="component://common/webcommon/includes/messages.ftl"/>
>> -
>> <property-map resource="CommonHelpUrls" map-
>> name="helpUrlsMap" global="true"/>
>> </actions>
>> <widgets>
>> @@ -209,7 +204,7 @@
>> <field-map field-name="userPrefGroupTypeId"
>> value="GLOBAL_PREFERENCES"/>
>> </service>
>> <set field="userPreferences" from-
>> field="prefResult.userPrefMap" global="true"/>
>> - +
>> <property-map resource="general" map-
>> name="generalProperties" global="true"/>
>> <set field="defaultVisualThemeId" from-
>> field="generalProperties.defaultVisualThemeId" default-
>> value="SMOOTH_FEATHER"/>
>> <set field="visualThemeId" from-
>> field="userPreferences.VISUAL_THEME" default-value="$
>> {defaultVisualThemeId}" global="true"/>