You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/02/13 12:07:29 UTC
[PR] [SPARK-55518][INFRA][PYTHON][DOCS] Upgrade Python to 3.12 in doc build [spark]
zhengruifeng opened a new pull request, #54310:
URL: https://github.com/apache/spark/pull/54310
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Upgrade Python to 3.12 in doc build
### Why are the changes needed?
1, Upgrade Python to 3.12 in doc build;
2, Unpin `pyzmq<24.0.0` introduced in https://github.com/apache/spark/pull/37904 for python linter, otherwise the python installation fails
### Does this PR introduce _any_ user-facing change?
No, infra-only
### How was this patch tested?
CI, the PR builder should cover this change
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55518][INFRA][PYTHON][DOCS] Upgrade Python to 3.12 in doc build [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #54310:
URL: https://github.com/apache/spark/pull/54310#discussion_r2819936407
##########
.github/workflows/build_and_test.yml:
##########
@@ -1104,11 +1104,14 @@ jobs:
- name: List Python packages for branch-3.5 and branch-4.0
if: inputs.branch == 'branch-3.5' || inputs.branch == 'branch-4.0'
run: python3.9 -m pip list
+ - name: List Python packages for branch-4.1
+ if: inputs.branch == 'branch-4.1'
+ run: python3.11 -m pip list
Review Comment:
I see this in step `initialize container`
```
Starting job container
/usr/bin/docker --config /home/runner/work/_temp/.docker_1e82e198-95d9-412d-9a06-2c22a7072071 login ghcr.io -u zhengruifeng --password-stdin
/usr/bin/docker --config /home/runner/work/_temp/.docker_1e82e198-95d9-412d-9a06-2c22a7072071 pull ghcr.io/zhengruifeng/apache-spark-ci-image-docs:branch-4.1-22123192824
```
https://github.com/zhengruifeng/spark/actions/runs/22123192824/job/63947748574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55518][INFRA][PYTHON][DOCS] Upgrade Python to 3.12 in doc build [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #54310: [SPARK-55518][INFRA][PYTHON][DOCS] Upgrade Python to 3.12 in doc build
URL: https://github.com/apache/spark/pull/54310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55518][INFRA][PYTHON][DOCS] Upgrade Python to 3.12 in doc build [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #54310:
URL: https://github.com/apache/spark/pull/54310#discussion_r2819934728
##########
.github/workflows/build_and_test.yml:
##########
@@ -1104,11 +1104,14 @@ jobs:
- name: List Python packages for branch-3.5 and branch-4.0
if: inputs.branch == 'branch-3.5' || inputs.branch == 'branch-4.0'
run: python3.9 -m pip list
+ - name: List Python packages for branch-4.1
+ if: inputs.branch == 'branch-4.1'
+ run: python3.11 -m pip list
Review Comment:
https://github.com/apache/spark/pull/54354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55518][INFRA][PYTHON][DOCS] Upgrade Python to 3.12 in doc build [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #54310:
URL: https://github.com/apache/spark/pull/54310#discussion_r2819918443
##########
.github/workflows/build_and_test.yml:
##########
@@ -1104,11 +1104,14 @@ jobs:
- name: List Python packages for branch-3.5 and branch-4.0
if: inputs.branch == 'branch-3.5' || inputs.branch == 'branch-4.0'
run: python3.9 -m pip list
+ - name: List Python packages for branch-4.1
+ if: inputs.branch == 'branch-4.1'
+ run: python3.11 -m pip list
Review Comment:
> This PR seems to remove Python 3.11 installation step in the Docker file for branch-4.1
I guess it is using a different image, since `github.ref_name` is used as the tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55518][INFRA][PYTHON][DOCS] Upgrade Python to 3.12 in doc build [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #54310:
URL: https://github.com/apache/spark/pull/54310#issuecomment-3924121063
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55518][INFRA][PYTHON][DOCS] Upgrade Python to 3.12 in doc build [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #54310:
URL: https://github.com/apache/spark/pull/54310#discussion_r2805023634
##########
.github/workflows/build_and_test.yml:
##########
@@ -1104,11 +1104,14 @@ jobs:
- name: List Python packages for branch-3.5 and branch-4.0
if: inputs.branch == 'branch-3.5' || inputs.branch == 'branch-4.0'
run: python3.9 -m pip list
+ - name: List Python packages for branch-4.1
+ if: inputs.branch == 'branch-4.1'
+ run: python3.11 -m pip list
Review Comment:
For my understanding: This PR seems to remove `Python 3.11` installation step in the Docker file for `branch-4.1`. Where does this `python 3.11` come from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55518][INFRA][PYTHON][DOCS] Upgrade Python to 3.12 in doc build [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #54310:
URL: https://github.com/apache/spark/pull/54310#discussion_r2805023634
##########
.github/workflows/build_and_test.yml:
##########
@@ -1104,11 +1104,14 @@ jobs:
- name: List Python packages for branch-3.5 and branch-4.0
if: inputs.branch == 'branch-3.5' || inputs.branch == 'branch-4.0'
run: python3.9 -m pip list
+ - name: List Python packages for branch-4.1
+ if: inputs.branch == 'branch-4.1'
+ run: python3.11 -m pip list
Review Comment:
This PR seems to remove `Python 3.11` installation step in the Docker file for `branch-4.1`. Where does this `python 3.11` come from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55518][INFRA][PYTHON][DOCS] Upgrade Python to 3.12 in doc build [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #54310:
URL: https://github.com/apache/spark/pull/54310#discussion_r2819925867
##########
.github/workflows/build_and_test.yml:
##########
@@ -1104,11 +1104,14 @@ jobs:
- name: List Python packages for branch-3.5 and branch-4.0
if: inputs.branch == 'branch-3.5' || inputs.branch == 'branch-4.0'
run: python3.9 -m pip list
+ - name: List Python packages for branch-4.1
+ if: inputs.branch == 'branch-4.1'
+ run: python3.11 -m pip list
Review Comment:
let me check it with a 4.1 PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org