You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/07/19 17:39:26 UTC
[GitHub] [brooklyn-ui] algairim opened a new pull request #252: Logbook widget in app inspector
algairim opened a new pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252
Logbook widget has been enhanced with multi-phrase search. `searchId` is now a minimum phrase to match with, if supplied in the directive arguments.
<img width="1449" alt="Screenshot 2021-07-19 at 18 38 50" src="https://user-images.githubusercontent.com/81319331/126202883-abaf43f6-4428-4fdc-b083-cd836d29f26c.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
algairim commented on pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#issuecomment-883396844
Added logbook specific in parentheses.
<img width="961" alt="Screenshot 2021-07-20 at 14 32 58" src="https://user-images.githubusercontent.com/81319331/126332971-7b4e35ae-4844-48ff-97dc-cb2ee690693f.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
algairim commented on pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#issuecomment-883202507
Couple of UX questions:
* Do we want to preform an initial single query or start auto-query with default search parameter automatically (It is no at the moment)?
* Would it be better to add activity ID as part of logbook header, so that it will be explicit and imply that logbook is for this activity ID only, meaning some filter applied already. Like the following:
<img width="251" alt="Screenshot 2021-07-20 at 09 24 56" src="https://user-images.githubusercontent.com/81319331/126287546-35c7a854-c922-4671-a5ff-03be161c34af.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
algairim commented on pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#issuecomment-883238916
Depends on https://github.com/apache/brooklyn-server/pull/1208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
algairim commented on pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#issuecomment-883400583
Same for activities:
<img width="961" alt="Screenshot 2021-07-20 at 14 38 23" src="https://user-images.githubusercontent.com/81319331/126333826-48a39b67-41d6-49a0-9b03-406fc0ea9dab.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim edited a comment on pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
algairim edited a comment on pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#issuecomment-883202507
Couple of UX questions:
* Do we want to preform an initial single query or start auto-query with default search parameter automatically (It is not automatic at the moment, just a logbook query window as on screenshot above)?
* Would it be better to add activity ID as part of logbook header, so that it will be explicit and imply that logbook is for this activity ID only, meaning some filter applied already. Like the following:
<img width="251" alt="Screenshot 2021-07-20 at 09 24 56" src="https://user-images.githubusercontent.com/81319331/126287546-35c7a854-c922-4671-a5ff-03be161c34af.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim edited a comment on pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
algairim edited a comment on pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#issuecomment-883202507
Couple of UX questions:
* Do we want to preform an initial single query or start auto-query with default search parameter automatically (It is not automatic at the moment, just a logbook query window as on screenshot above)?
* Would it be better to add activity ID as part of logbook header, so that it will be explicit and imply that logbook is for this activity ID only, meaning some filter applied already. Like the following:
<img width="251" alt="Screenshot 2021-07-20 at 09 24 56" src="https://user-images.githubusercontent.com/81319331/126287546-35c7a854-c922-4671-a5ff-03be161c34af.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
algairim commented on pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#issuecomment-883202507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#discussion_r673364041
##########
File path: ui-modules/utils/logbook/logbook.js
##########
@@ -91,8 +91,6 @@ export function logbook() {
$scope.fieldsToShow = ['timestamp', 'class', 'message']
$scope.logFields = [
{name: 'Timestamp', value: 'timestamp', selected: true},
- {name: 'Task ID', value: 'taskId', selected: false},
- {name: 'Entity IDs', value: 'entityIds', selected: false},
Review comment:
@jcabrerizo, there is no dedicated task ID end entity ID columns in logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#discussion_r673364041
##########
File path: ui-modules/utils/logbook/logbook.js
##########
@@ -91,8 +91,6 @@ export function logbook() {
$scope.fieldsToShow = ['timestamp', 'class', 'message']
$scope.logFields = [
{name: 'Timestamp', value: 'timestamp', selected: true},
- {name: 'Task ID', value: 'taskId', selected: false},
- {name: 'Entity IDs', value: 'entityIds', selected: false},
Review comment:
@jcabrerizo, there is no task ID or entity ID in logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#discussion_r673374546
##########
File path: ui-modules/utils/logbook/logbook.js
##########
@@ -91,8 +91,6 @@ export function logbook() {
$scope.fieldsToShow = ['timestamp', 'class', 'message']
$scope.logFields = [
{name: 'Timestamp', value: 'timestamp', selected: true},
- {name: 'Task ID', value: 'taskId', selected: false},
- {name: 'Entity IDs', value: 'entityIds', selected: false},
Review comment:
Ok, I see now, reverting back.
<img width="1267" alt="Screenshot 2021-07-20 at 19 19 59" src="https://user-images.githubusercontent.com/81319331/126375392-87950cd4-35ec-4f96-827c-72e5fd7a6069.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] jcabrerizo merged pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
jcabrerizo merged pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] jcabrerizo commented on a change in pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
jcabrerizo commented on a change in pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#discussion_r673365261
##########
File path: ui-modules/utils/logbook/logbook.js
##########
@@ -91,8 +91,6 @@ export function logbook() {
$scope.fieldsToShow = ['timestamp', 'class', 'message']
$scope.logFields = [
{name: 'Timestamp', value: 'timestamp', selected: true},
- {name: 'Task ID', value: 'taskId', selected: false},
- {name: 'Entity IDs', value: 'entityIds', selected: false},
Review comment:
Have you tried to invoke an effector? Is how I teste it and the taks Id was there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim edited a comment on pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
algairim edited a comment on pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#issuecomment-883202507
Couple of UX questions:
* Do we want to preform an initial single query or start auto-query with default search parameter automatically (It is not automatic at the moment, just a logbook query window as on screenshot above)?
* Would it be better to add activity ID as part of logbook header, so that it will be explicit and imply that logbook is for this activity ID only, meaning some filter applied already. Like the following:
<img width="251" alt="Screenshot 2021-07-20 at 09 24 56" src="https://user-images.githubusercontent.com/81319331/126287546-35c7a854-c922-4671-a5ff-03be161c34af.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #252: Logbook widget in app inspector
Posted by GitBox <gi...@apache.org>.
algairim commented on pull request #252:
URL: https://github.com/apache/brooklyn-ui/pull/252#issuecomment-883202507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org