You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/11 17:42:36 UTC

[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5401: sim: initial support sim:nsh on MacOS M1 and Linux ARM64 based hosts.

ptka commented on a change in pull request #5401:
URL: https://github.com/apache/incubator-nuttx/pull/5401#discussion_r804873369



##########
File path: arch/sim/include/setjmp.h
##########
@@ -111,7 +145,8 @@
 
 #ifndef __ASSEMBLY__
 
-#if defined(CONFIG_HOST_X86_64) && !defined(CONFIG_SIM_M32)
+#if (defined(CONFIG_HOST_X86_64) && !defined(CONFIG_SIM_M32)) || \
+     defined(CONFIG_HOST_ARM64)

Review comment:
       Maybe, but "#if defined(CONFIG_HOST_X86_64) && !defined(CONFIG_SIM_M32)" was already in the code. I'm not sure, if other simulations will break. I get remove it and let the CI check?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org