You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/09/06 16:49:49 UTC
[Impala-ASF-CR](asf-site) Focus the website on Apache Impala (incubating), not Cloudera Impala.
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4318
Change subject: Focus the website on Apache Impala (incubating), not Cloudera Impala.
......................................................................
Focus the website on Apache Impala (incubating), not Cloudera Impala.
While I'm in here, remove outdated roadmap.
Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
---
M community.html
M index.html
M overview.html
3 files changed, 10 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/4318/1
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4318/2/community.html
File community.html:
Line 118: <li><a href="https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala">Contribute</a></li>
> I think removing the docs link is counterproductive. Feel free to highlight
Maybe I could word the link "Documentation (hosted by Cloudera)". What do you think?
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has submitted this change and it was merged.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
While I'm in here, remove outdated roadmap.
Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Reviewed-on: http://gerrit.cloudera.org:8080/4318
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Jim Apple <jb...@cloudera.com>
---
M bylaws.html
M community.html
R impala-docs.html
M index.html
M overview.html
5 files changed, 28 insertions(+), 64 deletions(-)
Approvals:
Jim Apple: Verified
Henry Robinson: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4318/2/community.html
File community.html:
Line 118: <li><a href="https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala">Contribute</a></li>
I think removing the docs link is counterproductive. Feel free to highlight that this goes to a non-Apache site, but there's a lot of useful information in the docs that we don't have an ASF equivalent of yet.
http://gerrit.cloudera.org:8080/#/c/4318/2/overview.html
File overview.html:
PS2, Line 150: We encourage you to read
Can you change the wording? "We encourage you to read" sounds very prescriptive to me. "This paper from CIDR '15 has the most complete overview of Impala's architecture" is how I'd rephrase.
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4318/2/community.html
File community.html:
Line 118: <li><a href="https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala">Contribute</a></li>
> Good idea!
Done
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4318
to look at the new patch set (#5).
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
While I'm in here, remove outdated roadmap.
Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
---
M bylaws.html
M community.html
R impala-docs.html
M index.html
M overview.html
5 files changed, 28 insertions(+), 64 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/4318/5
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4318
to look at the new patch set (#3).
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
While I'm in here, remove outdated roadmap.
Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
---
M bylaws.html
M community.html
R impala-docs.html
M index.html
M overview.html
5 files changed, 26 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/4318/3
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4318/4/impala-docs.html
File impala-docs.html:
Line 117: <li><a href="http://www.cloudera.com/content/cloudera-content/cloudera-docs/CDH5/latest/Impala/impala.html">Docs</a></li>
I think you should remove this link.
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4318/2/community.html
File community.html:
Line 118: <li><a href="https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala">Contribute</a></li>
> Better to be explicit that this is documentation for Impala in CDH. Perhaps
So, perhaps I could rename "books" to "docs", then have that page link to the three books and the CDH Impala docs?
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4318/4/impala-docs.html
File impala-docs.html:
Line 117: <li><a href="https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala">Contribute</a></li>
> I think you should remove this link.
Done
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
Patch Set 4:
Thoughts?
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#2).
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
While I'm in here, remove outdated roadmap.
Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
---
M community.html
M index.html
M overview.html
3 files changed, 10 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/4318/2
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4318/2/community.html
File community.html:
Line 118: <li><a href="https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala">Contribute</a></li>
> Maybe I could word the link "Documentation (hosted by Cloudera)". What do y
Better to be explicit that this is documentation for Impala in CDH. Perhaps it needs an intermediate page to give space to explain that.
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4318/2/community.html
File community.html:
Line 118: <li><a href="https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala">Contribute</a></li>
> So, perhaps I could rename "books" to "docs", then have that page link to t
Good idea!
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4318/2/community.html
File community.html:
Line 118: <li><a href="https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala">Contribute</a></li>
> So, perhaps I could rename "books" to "docs", then have that page link to t
Any more thoughts on this, Henry?
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4318
to look at the new patch set (#4).
Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
......................................................................
IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.
While I'm in here, remove outdated roadmap.
Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
---
M bylaws.html
M community.html
R impala-docs.html
M index.html
M overview.html
5 files changed, 26 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/4318/4
--
To view, visit http://gerrit.cloudera.org:8080/4318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0492bff6306089f0745bbff46f070cf3ad2d9c82
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>